-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/user #5139
Merged
Merged
Test/user #5139
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
12d3b55
Add some tests about user management.
Shylock-Hg c36b23a
Add tests about user roles.
Shylock-Hg 6ceb34e
Merge branch 'master' into test/user
Shylock-Hg f876d39
Format.
Shylock-Hg edc6512
Merge branch 'master' into test/user
Shylock-Hg bca56d8
Fix tck fixture name.
Shylock-Hg 4979863
Merge branch 'master' into test/user
Shylock-Hg 80c1374
Merge branch 'master' into test/user
Sophie-Xie e1e0eb4
Fix step name.
Shylock-Hg c1033df
Merge branch 'master' into test/user
Shylock-Hg 7a9d8ff
Merge branch 'master' into test/user
Shylock-Hg 8cacc86
Merge branch 'master' into test/user
Shylock-Hg 960d9a8
Change step name.
Shylock-Hg 7bc991e
Merge branch 'master' into test/user
Sophie-Xie ff245ea
Merge branch 'master' into test/user
Sophie-Xie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not to reset the current_session in exec_ctx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just verify logging, avoid affecting other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you don't change the current session, how do you make sure the next test cases use the current login user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next test will use origin session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if so, does this step just test whether the user exists? why not to use
show users
to test it? if you want to switch user and test role, plz consider to switch the current session.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be logged in by this user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just test login feature? what to do after the user login? I don't find where to use the login user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just test login.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not to test this feature in role cases ? such as:
it's not necessary to create a new step for this feature and we have the related step for switching user:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't want to change current session.