Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'attribute: huge' from config def file and C++ code. #22900

Closed
wants to merge 118 commits into from

Conversation

geirst
Copy link
Member

@geirst geirst commented Jun 3, 2022

@toregge please review

gjoranv and others added 30 commits June 2, 2022 21:42
Remove '.sum' from metric names for storage node and also remove the average metrics for the same.
Remove '.sum' from distributor metrics set and remove distributor average metrics.
GC '.sum' from distributor metric names.
Remove '.alldisks' from metric names and update tests.
GC '.alldisks' from filestor metrics.
- Records, switch statements and pattern matching for instanceof.
@geirst geirst requested a review from toregge June 3, 2022 11:18
@geirst
Copy link
Member Author

geirst commented Jun 3, 2022

@gjoranv or @arnej27959 please merge when factory is ok

@gjoranv
Copy link
Member

gjoranv commented Jun 3, 2022

Merged in another PR, right @geirst ?

@gjoranv gjoranv closed this Jun 3, 2022
@toregge
Copy link
Member

toregge commented Jun 3, 2022

The original changes in this PR (Remove 'attribute: huge' from config def file and C++ code.) have not been merged.

@toregge toregge reopened this Jun 3, 2022
@gjoranv
Copy link
Member

gjoranv commented Jun 3, 2022

Superseded by #22911

@gjoranv gjoranv closed this Jun 3, 2022
@baldersheim baldersheim deleted the geirst/remove-attribute-huge-config-def branch June 16, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.