Feature/create chat box #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sirbuland
force-pushed
the
feature/create_chat_box
branch
from
ef72726
to
4013a47
Compare
Sirbuland
force-pushed
the
feature/create_chat_box
branch
from
4013a47
to
a22da0a
Compare
HamptonMakes
approved these changes
Aug 17, 2020
| @@ -0,0 +1,11 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class ChatRoomChannel < ApplicationCable::Channel | |||
There was a problem hiding this comment.
Should this be live_video_channel and use it for hearts/messages/etc? Or is it better to have many types of channels?
| <p class="web--message__name"> | ||
| ${name} | ||
| </p> | ||
| <label class="web--message__label"> |
There was a problem hiding this comment.
Do you try and prefix everything with "web"? Why not put it on the body-tag and just use it everywhere?
| $medium-gray: #d0d0d0; | ||
|
|
||
| @mixin text-style ($f-size, $color, $f-family ,$f-weight) { |
There was a problem hiding this comment.
This definitely seems like it should be in the utils.
| $light-silver:#d8d8d8; | ||
| $light-blue: #616583; | ||
| $medium-gray: #d0d0d0; |
There was a problem hiding this comment.
Break these out into a vars.scss file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.