Feature/chat room isolation and fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamptonMakes
approved these changes
Aug 19, 2020
| @@ -13,7 +13,7 @@ def create | |||
| end | |||
|
|
|||
| ActionCable.server.broadcast( | |||
| "chat_room", | |||
| "live_video_#{message.video_id}", | |||
| {text: message.body, user_name: current_user.full_name, video_id: message.video_id}, | |||
There was a problem hiding this comment.
Do you need to pass the video id here as a param also? It is already going to the channel for it
There was a problem hiding this comment.
Yes, I'll take it and will try to eliminate it. Actually for video_id, we are using it inside received(data) of consumer.subscriptions.create. Another way is to take roomId from params like this JSON.parse(this.identifier).roomId
| ${data.text} | ||
| </label> | ||
| </div> | ||
| ` |
There was a problem hiding this comment.
It's like low-complexity JSX 😀
There was a problem hiding this comment.
yeah without render function.... 😄
| @@ -1,3 +1,7 @@ | |||
| @import '../vars'; | |||
| @import '../utils/text_style'; | |||
| @import '../utils/grid_style'; | |||
There was a problem hiding this comment.
I'll show you in a refactor PR how to use these with modules!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.