adds video_viewers count model #66
Conversation
| stream_from(stream_name) | ||
| end | ||
|
|
||
| def unsubscribed | ||
| current_video.update!(active_viewers: current_video.active_viewers - 1) if current_video.active_viewers | ||
| current_video.decrement_viewers! if current_video.active_viewers | ||
| stop_all_streams |
There was a problem hiding this comment.
I was actually going to ask about this in the first PR, but forgot to mention
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| class ChatMessagesController < ApplicationController | |||
| before_action :authenticate_user!, only: [:create] | |||
| before_action :current_video | |||
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
I'd rather keep the whole string!
| browser: browser_name, | ||
| } | ||
| end | ||
| end |
There was a problem hiding this comment.
You don't need this! This should just be on the VideosController#show action! No API call or controller required!
| @@ -90,6 +93,11 @@ export default class extends Controller { | |||
| ); | |||
| } | |||
|
|
|||
| incrementVideoViews(): void { | |||
| console.log(this.streamType); | |||
| if (this.streamType !== "live") post("./video_views"); | |||
There was a problem hiding this comment.
Live Views count as Views! But also, same comment it should just be server side.
| @@ -23,7 +23,7 @@ export default class ChatMessagesController extends BaseController { | |||
|
|
|||
| private displayMessage(message) { | |||
| const sameUser = message.userId === this.lastMessageFromUserId; | |||
| console.log(message); | |||
|
|
|||
There was a problem hiding this comment.
whoops, that's my fault
| before do | ||
| video.go_live! | ||
| end | ||
|
|
There was a problem hiding this comment.
hmmm, you should be able to use the factory :live_video to get this.
spec/factories/video_views.rb
Outdated
| video { nil } | ||
| details { "" } | ||
| end | ||
| end |
There was a problem hiding this comment.
Do you need this? I don't think so.
| video.reload | ||
| expect(video.video_views.size).to eq(1) | ||
| end | ||
| end |
There was a problem hiding this comment.
Should be in the VideosRequestSpec
|
Task linked: VEUE-137 Track Total Views (see description) |
Sirbuland
force-pushed
the
VEUE-137
branch
2 times, most recently
from
bd71b5d
to
2845b8b
Compare
This PR adds a model in database for keeping record of viewers of a video which is not live. We are also maintaining its count in video table in
video_viwerers_countusing counter_cache provided by active_record.