CU-bcqgq6 Feature/design chat area #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HamptonMakes
requested changes
Aug 24, 2020
Sirbuland
force-pushed
the
feature/design_chat_area
branch
from
2ac32c0
to
7b074b4
Compare
Sirbuland
force-pushed
the
feature/design_chat_area
branch
from
3740068
to
10b96b6
Compare
Sirbuland
force-pushed
the
feature/design_chat_area
branch
from
bdb6d5c
to
9442fcd
Compare
HamptonMakes
changed the title
|
Task linked: CU-bcqgq6 Basic Chat |
HamptonMakes
approved these changes
Aug 25, 2020
| @@ -1,7 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class ChatMessagesController < ApplicationController | |||
| before_action :messages_params | |||
| before_action :messages_params, only: [:create] | |||
| ActionCable.server.broadcast( | ||
| "live_video_#{message.video_id}", | ||
| {text: message.body, user_name: current_user.full_name, video_id: message.video_id}, | ||
| ) |
|
|
||
| module ChatHelper | ||
| def current_user_id | ||
| user_signed_in? ? current_user.id : "" |
There was a problem hiding this comment.
seems like we should return something falsey here, right? Maybe even false itself?
| user_name: user.username.capitalize, | ||
| }, | ||
| ) | ||
| end |
There was a problem hiding this comment.
👍 much better place for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.