Adds AboutXml topic #301

indented-automation · 2019-10-25T20:20:24Z

PR Summary

Fixes #255

Context

Adds koans which explore working with XML

Changes

Adds AboutKoans topic.

Checklist

Pull Request has a meaningful title.
Summarised changes.
Pull Request is ready to merge & is not WIP.
Added tests / only testable interactively.
- Make sure you add a new test if old tests do not effectively test the code changed.
Added documentation / opened issue to track adding documentation at a later date.

vexx32

1st pass! Only got about halfway through, but hopefully some of this is helpful! 😁

PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

vexx32

Mostly minor stuff for the second half, by the looks of it.

Otherwise looks quite solid, nice work. Thanks! 😊

PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

vexx32 · 2020-01-08T15:56:54Z

PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

+            The URI used for a namespace is often made-up, it does not have to exist on the Internet. The namespace
+            must be unique within the document.


Weird. Is there a history behind this I can read up on? Seems odd to use a URI if that won't really exist most of the time. 🤔

You can find similar statements around. It's not used by the parser (except as a unique value), so you can just make it up and XML parsers will accept it as valid.

For instance, take a MAML document. It has many, many, many namespaces. Picking the first from base.xsd, it looks perfectly valid:

https://schemas.microsoft.com/maml/2004/10

And it may even have worked at one time. It doesn't any more though. Nothing will care, all of the schema files are locally available at the end of the day.

vexx32 · 2020-01-08T15:58:43Z

PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

+            XML documents may declare more than one namespace. Additional namespaces are declared with a prefix.
+
+                <root xmlns="http://someuri/default.xsd" xmlns:prefix="http://someuri/prefix.xsd">
+                    ...
+                </root>
+
+            The prefix name is arbitrary but must be consistent within a document.


What's the common usage for additional namespaces in the one doc? Seems like an odd thing to have for XML. O.o

Code / schema reuse most often I suppose. Never had to design and XML schema so I don't really know to be honest :)

I was going to push a Group Policy document in there as an example. They're "wonderful" for massive use of namespaces. Decided against it though, difficult to make it actually useful.

Might be an interesting thing to pursue for a kata 😉

PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

vexx32

Looks good to me on the whole.

@steviecoaster did you want to give this one a quick pass?

Adds framework

036ebc3

indented-automation requested review from steviecoaster and vexx32 as code owners October 25, 2019 20:20

Merge branch 'master' into AddsAboutXml

08636ec

vexx32 added Category-Koans Invoking the Great Doubt PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. labels Oct 25, 2019

vexx32 changed the title ~~Adds AboutKoans topic~~ Adds AboutXml topic Oct 26, 2019

indented-automation added 9 commits October 27, 2019 21:08

Starting to add XPath

546c473

Adds Select-Xml, Select methods, and XmlWriter

d9d7253

Adds document modification

9da4d6f

Merge branch 'master' into AddsAboutXml

eb49863

Gets rid of that line break

f491e01

Fixes RemoveAll / RemoveChild examples

7dfe442

Adds namespace handling

11e132b

Merge branch 'master' into AddsAboutXml

03f6397

Adds AboutXml to index

c24e776

vexx32 added PR-Needs-Review 🔍 Let's take a closer look! and removed PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. labels Jan 2, 2020

vexx32 requested changes Jan 6, 2020

View reviewed changes

indented-automation and others added 10 commits January 8, 2020 08:21

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

518fcaa

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

f8dc626

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

fc0126a

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

318f262

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

79575f9

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

92ed45b

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

2cc04c0

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

9567af0

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

d3eb935

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

dea5f45

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

indented-automation and others added 3 commits January 8, 2020 08:23

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

d26d41d

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Merge branch 'master' into AddsAboutXml

3006b93

Review fixes

23e00ba

vexx32 requested changes Jan 8, 2020

View reviewed changes

indented-automation and others added 4 commits January 10, 2020 16:11

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

291a6a9

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Update PSKoans/Koans/Constructs and Patterns/AboutXml.Koans.ps1

1077b2f

Co-Authored-By: Joel Sallow (/u/ta11ow) <32407840+vexx32@users.noreply.github.com>

Review fixes

744d4d2

Merge branch 'master' into AddsAboutXml

81d70d9

vexx32 approved these changes Jan 10, 2020

View reviewed changes

vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Jan 13, 2020

vexx32 merged commit a1f0830 into vexx32:master Jan 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds AboutXml topic #301

Adds AboutXml topic #301

indented-automation commented Oct 25, 2019 •

edited by vexx32

Loading

vexx32 left a comment

vexx32 left a comment

vexx32 Jan 8, 2020

indented-automation Jan 10, 2020

vexx32 Jan 8, 2020

indented-automation Jan 10, 2020

indented-automation Jan 10, 2020

vexx32 Jan 10, 2020

vexx32 left a comment

		The URI used for a namespace is often made-up, it does not have to exist on the Internet. The namespace
		must be unique within the document.

Adds AboutXml topic #301

Adds AboutXml topic #301

Conversation

indented-automation commented Oct 25, 2019 • edited by vexx32 Loading

PR Summary

Context

Changes

Checklist

vexx32 left a comment

Choose a reason for hiding this comment

vexx32 left a comment

Choose a reason for hiding this comment

vexx32 Jan 8, 2020

Choose a reason for hiding this comment

indented-automation Jan 10, 2020

Choose a reason for hiding this comment

vexx32 Jan 8, 2020

Choose a reason for hiding this comment

indented-automation Jan 10, 2020

Choose a reason for hiding this comment

indented-automation Jan 10, 2020

Choose a reason for hiding this comment

vexx32 Jan 10, 2020

Choose a reason for hiding this comment

vexx32 left a comment

Choose a reason for hiding this comment

indented-automation commented Oct 25, 2019 •

edited by vexx32

Loading