Properly quote path argument to Start-Process

[vexx32]

PR Summary

Start-Process doesn't pass through non-explicit quotes.
This unfortunately means paths with spaces get read as two arguments.

Fix is to properly insert explicit quotes to the argument first.

Context

There's no reason not to support spaces in paths. This is 2019, c'mon. 😋

Resolves #306

Changes

• Tidy up path resolution logic.
• Refactor Start-Process splat table to insert explicit quotes in the path argument.

Checklist

• Pull Request has a meaningful title.
• Summarised changes.
• Pull Request is ready to merge & is not WIP.
• Added tests / only testable interactively.
  • Make sure you add a new test if old tests do not effectively test the code changed.
• Added documentation / opened issue to track adding documentation at a later date.

[camusicjunkie]

Your modified code looks like what was previously implemented before #289. Will this create the issue again described in #284?

[vexx32]

@camusicjunkie the issue in #284 arose because we didn't think to use either Resolve-Path or Get-Item before passing the path to Start-Process. Provided we do that, this should continue to work.

The reason I reverted to a more similar pattern to the original is mainly because I suspect the additional complexity of the methods utilized in #289 made it harder for us to catch the regression here in terms of proper handling of paths with spaces during review.

If you'd like to verify for yourself, you can pull the built module from the CI artifacts and test to be sure it behaves as you'd expect. 😊

I'll look into possible avenues of expanding our testing to ensure we don't get tripped up like this again! 💖