Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AboutCmdletVerbs #378

Merged
merged 4 commits into from
Mar 21, 2020
Merged

Refactor AboutCmdletVerbs #378

merged 4 commits into from
Mar 21, 2020

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Mar 12, 2020

PR Summary

Quick pass over AboutCmdletVerbs to tidy it up a bit, get it in line with the rest of the introductory topics.

Changes

  • Constrain block comment widths a bit to make it a bit easier to read (hopefully).
  • Tidy code a bit.
  • Rephrase / adjust commentary where needed.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Koans Invoking the Great Doubt labels Mar 12, 2020
@vexx32 vexx32 force-pushed the AboutCmdletVerbs/Refactoer branch from 6999d65 to e4c262a Compare March 12, 2020 23:53
@vexx32 vexx32 force-pushed the AboutCmdletVerbs/Refactoer branch 4 times, most recently from 6b4fb98 to 6757e53 Compare March 13, 2020 00:12
@vexx32 vexx32 force-pushed the AboutCmdletVerbs/Refactoer branch from 6757e53 to 37df6d5 Compare March 13, 2020 00:27
Copy link
Collaborator

@steviecoaster steviecoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only marked a few spots here. There are a couple more, but was getting repetitive

PSKoans/Koans/Introduction/AboutCmdletVerbs.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Introduction/AboutCmdletVerbs.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Introduction/AboutCmdletVerbs.Koans.ps1 Outdated Show resolved Hide resolved
Copy link
Contributor

@Maamue Maamue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest to use different examples than Office 365, not everyone will have to interact with Exchange and will never see these Cmdlets, or at least give an eample additional exmaple cmdlet to the Exchange calendar cmdlets. Focus is on th verbs so the noun should be agnostic, I still think it may help readers in their learning process.

Otherwise I spotted some typos here and there.

PSKoans/Koans/Introduction/AboutCmdletVerbs.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Introduction/AboutCmdletVerbs.Koans.ps1 Outdated Show resolved Hide resolved
PSKoans/Koans/Introduction/AboutCmdletVerbs.Koans.ps1 Outdated Show resolved Hide resolved
@vexx32
Copy link
Owner Author

vexx32 commented Mar 14, 2020

@Maamue I agree the office 365 isn't the most applicable example for everyone. The "generic" example, so to speak, is the *-Item / *-Content cmdlets, which I've gone through and added as a series of practical exercises, taking the place of the extra commentary.

Is there a better / more applicable secondary example than office 365 cmdlets for this purpose, do you think? Perhaps we'd be better off varying the examples rather than using examples all from the same module?

@vexx32 vexx32 force-pushed the AboutCmdletVerbs/Refactoer branch from 058a941 to 569a6cd Compare March 14, 2020 05:52
@vexx32 vexx32 merged commit b16400c into master Mar 21, 2020
@vexx32 vexx32 deleted the AboutCmdletVerbs/Refactoer branch March 21, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants