-
-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to EZOut for formatting #382
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexx32
added
PR-Needs-Review 🔍
Let's take a closer look!
Category-Module
Pertaining to the module's functionality itself.
Category-Build 🚀
Modifies the build / deployment system
labels
Mar 21, 2020
- Add format view for result object - Add build code to generate xml
+ Refactoring on some controls + Added formatting for PSKoans.CompleteResult + All cases tested and looking fancy!
- Removed Show-MeditationPrompt
vexx32
force-pushed
the
Formatting/EzFormat
branch
from
March 21, 2020 23:17
8a74b40
to
50898f1
Compare
vexx32
force-pushed
the
Formatting/EzFormat
branch
from
March 21, 2020 23:33
779432e
to
5de519b
Compare
vexx32
force-pushed
the
Formatting/EzFormat
branch
from
March 22, 2020 00:03
6e45498
to
3a11b76
Compare
+ Remove mocks and checks for Show-MeditationPrompt + Other small fixes for slight behaviour changes
vexx32
force-pushed
the
Formatting/EzFormat
branch
from
March 22, 2020 02:34
2a8245d
to
781c083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category-Build 🚀
Modifies the build / deployment system
Category-Module
Pertaining to the module's functionality itself.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Using
EZOut
module for formatting allows us to build the formatting data from PowerShell code easily, replacing the need forShow-MeditationPrompt
with a simple call toFormat-Custom
.The only missing piece here is the intro text. While it probably won't be missed for the first few sections, a few of the later koans can take some time to process. We may want to look into adding some progress bars or other indicator to the user that the command has not hung.
@StartAutomating if you have a minute to give this a look over, it'd be greatly appreciated! 💖
Changes
formatting
folder.EZOut
build script.Checklist