Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to EZOut for formatting #382

Merged
merged 14 commits into from
Apr 30, 2020
Merged

Move to EZOut for formatting #382

merged 14 commits into from
Apr 30, 2020

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Mar 21, 2020

PR Summary

Using EZOut module for formatting allows us to build the formatting data from PowerShell code easily, replacing the need for Show-MeditationPrompt with a simple call to Format-Custom.

The only missing piece here is the intro text. While it probably won't be missed for the first few sections, a few of the later koans can take some time to process. We may want to look into adding some progress bars or other indicator to the user that the command has not hung.

@StartAutomating if you have a minute to give this a look over, it'd be greatly appreciated! 💖

Changes

  • Create format definition files in formatting folder.
  • Add EZOut build script.
  • Call to EZOut script when building the module to generate the XML formatting.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Module Pertaining to the module's functionality itself. Category-Build 🚀 Modifies the build / deployment system labels Mar 21, 2020
- Add format view for result object
- Add build code to generate xml
+ Refactoring on some controls
+ Added formatting for PSKoans.CompleteResult
+ All cases tested and looking fancy!
- Removed Show-MeditationPrompt
@vexx32
Copy link
Owner Author

vexx32 commented Apr 30, 2020

Screenshots; Show-Karma is now basically a shortcut for Get-Karma | Format-Custom plus some bells and whistles.

image

@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Apr 30, 2020
@vexx32 vexx32 merged commit fa538b0 into master Apr 30, 2020
@vexx32 vexx32 deleted the Formatting/EzFormat branch April 30, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category-Build 🚀 Modifies the build / deployment system Category-Module Pertaining to the module's functionality itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant