Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -NoNewWindow to Start-Process in Show-Karma -Meditat #397

Merged
merged 2 commits into from
Jun 14, 2020

Conversation

vexx32
Copy link
Owner

@vexx32 vexx32 commented Jun 14, 2020

PR Summary

Start-Process by default opens a new console. We generally do not want this to be the case for Show-Karma -Meditate.

Context

Fixes #395

Changes

  • Add -NoNewWindow to Start-Process call in Show-Karma

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Start-Process by default opens a new console. We generally do not want
this to be the case for Show-Karma -Meditate.
@vexx32 vexx32 added the PR-Needs-Review 🔍 Let's take a closer look! label Jun 14, 2020
@vexx32 vexx32 merged commit 247dcc1 into main Jun 14, 2020
@vexx32 vexx32 deleted the Show-Karma/NoNewWindow-Meditate branch June 14, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Needs-Review 🔍 Let's take a closer look!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show-Karma -Meditate briefly opens a new console window
1 participant