Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Review] Improve documentation #81

Merged
merged 58 commits into from
Sep 28, 2022
Merged

[Review] Improve documentation #81

merged 58 commits into from
Sep 28, 2022

Conversation

vferat
Copy link
Owner

@vferat vferat commented Sep 13, 2022

Code

  • Improve control of ModK.plot()

Documentation

  • Add bibliography
  • Add glossary
  • Add Note to explain invert_polarity purpose
  • Improve metrics tutorial
  • Improve resampling tutorial
    • Replicate Cartool pipelines
    • Study stability of topographies

Paper

  • Add missing python packages (neurokit, keypy)
  • Add more details on the value offered by Pycrostates including:
    • Class based implementation (reusable components)
    • Group level analysis
    • Advanced segmentation (smoothing)

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #81 (7c1ba49) into main (5cedca5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
- Coverage   96.34%   96.33%   -0.01%     
==========================================
  Files          56       54       -2     
  Lines        4127     4120       -7     
==========================================
- Hits         3976     3969       -7     
  Misses        151      151              
Impacted Files Coverage Δ
pycrostates/cluster/kmeans.py 97.77% <ø> (ø)
pycrostates/metrics/calinski_harabasz.py 100.00% <ø> (ø)
pycrostates/metrics/davies_bouldin.py 97.50% <ø> (ø)
pycrostates/metrics/dunn.py 100.00% <ø> (ø)
pycrostates/metrics/silhouette.py 100.00% <ø> (ø)
pycrostates/preprocessing/extract_gfp_peaks.py 100.00% <ø> (ø)
pycrostates/viz/cluster_centers.py 94.64% <ø> (ø)
pycrostates/cluster/_base.py 93.42% <100.00%> (+0.01%) ⬆️
pycrostates/tests/test_utils.py
pycrostates/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@mscheltienne mscheltienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments while I had some wifi, energy and time :)

I haven't noted all the mentions of (thus, thuse,) or of leading space, or 'summurizes'.

Have a look when you have time, I'll have a look again when I'll get back ;)

docs/source/conf.py Outdated Show resolved Hide resolved
docs/source/microstates/bibliography.rst Show resolved Hide resolved
docs/source/microstates/glossary.rst Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
pycrostates/metrics/davies_bouldin.py Outdated Show resolved Hide resolved
tutorials/metrics/plot_metrics.py Outdated Show resolved Hide resolved
tutorials/metrics/plot_metrics.py Outdated Show resolved Hide resolved
tutorials/metrics/plot_metrics.py Outdated Show resolved Hide resolved
tutorials/preprocessing/plot_extract_gfp_peaks.py Outdated Show resolved Hide resolved
tutorials/preprocessing/plot_extract_gfp_peaks.py Outdated Show resolved Hide resolved
Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com>
@mscheltienne mscheltienne changed the title [Review] [Review] Improve documentation Sep 26, 2022
Copy link
Collaborator

@mscheltienne mscheltienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vferat vferat merged commit cc12f76 into main Sep 28, 2022
@mscheltienne mscheltienne deleted the dev-docs branch September 28, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants