Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to install 4.1.0 fails due to otel deps #287

Closed
agis opened this issue Jul 4, 2024 · 10 comments · Fixed by #288
Closed

Trying to install 4.1.0 fails due to otel deps #287

agis opened this issue Jul 4, 2024 · 10 comments · Fixed by #288

Comments

@agis
Copy link

agis commented Jul 4, 2024

Apparently otel removed some of their previously-working import paths (open-telemetry/opentelemetry-go#2897), so we might need to bump their versions in the v4 branch.

$ go get -u github.com/vgarvardt/gue/v4
go: github.com/vgarvardt/gue/v4 imports
	go.opentelemetry.io/otel/metric/instrument: cannot find module providing package go.opentelemetry.io/otel/metric/instrument
go: github.com/vgarvardt/gue/v4 imports
	go.opentelemetry.io/otel/metric/instrument/syncint64: cannot find module providing package go.opentelemetry.io/otel/metric/instrument/syncint64
go: github.com/vgarvardt/gue/v4 imports
	go.opentelemetry.io/otel/metric/unit: cannot find module providing package go.opentelemetry.io/otel/metric/unit
@vgarvardt
Copy link
Owner

Starting from v1.25.0 OTel requires go 1.21 and gue is currently pinned to go 1.20. I'll bump min required version to 1.21 since 1.20 reached end of support already.

@vgarvardt
Copy link
Owner

vgarvardt commented Jul 4, 2024

pls check if https://github.com/vgarvardt/gue/releases/tag/v5.7.0 solves your problem

PS GH closed the issue automatically after the linked PR was merged

@agis
Copy link
Author

agis commented Jul 4, 2024 via email

@vgarvardt
Copy link
Owner

oh, v4 - this version is not support anymore, most likely you'd need to create your fork

@agis
Copy link
Author

agis commented Jul 5, 2024

Would you be open to a PR backporting this in v4, so that we avoid forking?

@vgarvardt
Copy link
Owner

I do not even have a separate branch with v4, will try to create one later today from the commit before switched to v5

@vgarvardt vgarvardt reopened this Jul 5, 2024
@agis
Copy link
Author

agis commented Jul 5, 2024

Thanks a lot!

@agis
Copy link
Author

agis commented Jul 16, 2024

If I can do anything to help, please let me know.

@vgarvardt
Copy link
Owner

just merged #290 to newly created v4 branch. Pls check if it solves your problem. If all good - I'll release 4.2.0

@agis
Copy link
Author

agis commented Sep 3, 2024

Thanks, closing this as it's resolved.

@agis agis closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants