Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vg map issue using pacbio reads #662

Closed
shilpagarg opened this issue Feb 12, 2017 · 8 comments · Fixed by #676
Closed

vg map issue using pacbio reads #662

shilpagarg opened this issue Feb 12, 2017 · 8 comments · Fixed by #676
Assignees

Comments

@shilpagarg
Copy link

shilpagarg commented Feb 12, 2017

Hi, I am aligning pacbio reads using vg map.

vg map -x true_yeast_graph_X.xg -g true_yeast_graph_X.gcsa -f yeast_pacbio.fastq > yeast_pacbio.gam

and I get

terminate called after throwing an instance of 'std::runtime_error'
what(): Cannot simplify Mapping with no position; must update position when removing leading deletions
Aborted

@ekg
Copy link
Member

ekg commented Feb 12, 2017

This may be related to the previous problem that Adam reported, where we have a failure during alignment simplification.

However, it isn't possible to know because this report does not include enough data to reproduce the failure. Would you please upload the input graph, the failing alignment, and write the commands which you used for indexing?

As an aside, do we know that the pacbio alignments are correct? What about simulating some reads with the right error rates and lengths and aligning them with given to vg map --compare? The output is a table that describes how accurate the reads are.

@ekg
Copy link
Member

ekg commented Feb 12, 2017

This is vg map --compare:

% vg map --help 2>&1 | grep compare
    -w, --compare         consider GAM input (-G) as truth, table of name, overlap with truth, identity, score, mapqual

If vg map is aligning a GAM that was simulated, then it measures how much of the realignment matches the original ground truth.

Using this with vg sim is critical to understand if we are getting correct alignments. Also, running this interactively will help show if the alignments are taking a reasonable amount of time. It may be that we need to set different parameters for long reads. We may, as long reads haven't been tested on the current version of vg's aligner.

@shilpagarg
Copy link
Author

shilpagarg commented Feb 13, 2017

here is the back-trace:

#0  0x00007ffff5b14035 in __GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#1  0x00007ffff5b1779b in __GI_abort () at abort.c:91
#2  0x00007ffff662421d in __gnu_cxx::__verbose_terminate_handler() () at /lustre/scratch110/sanger/gt1/build/gcc/gcc-4.9.2-src/libstdc++-v3/libsupc++/vterminate.cc:95
#3  0x00007ffff6622286 in __cxxabiv1::__terminate(void (*)()) () at /lustre/scratch110/sanger/gt1/build/gcc/gcc-4.9.2-src/libstdc++-v3/libsupc++/eh_terminate.cc:47
#4  0x00007ffff6621379 in __cxa_call_terminate () at /lustre/scratch110/sanger/gt1/build/gcc/gcc-4.9.2-src/libstdc++-v3/libsupc++/eh_call.cc:54
#5  0x00007ffff6621adb in __gxx_personality_v0 () at /lustre/scratch110/sanger/gt1/build/gcc/gcc-4.9.2-src/libstdc++-v3/libsupc++/eh_personality.cc:670
#6  0x00007ffff5eabf53 in _Unwind_RaiseException_Phase2 () from /software/hpag/gcc/4.9.2/lib64/libgcc_s.so.1
#7  0x00007ffff5eac477 in _Unwind_Resume () from /software/hpag/gcc/4.9.2/lib64/libgcc_s.so.1
#8  0x000000000075bc5a in vg::Mapper::align_banded(vg::Alignment const&, int, int, int, int) () at /software/hpag/gcc/4.9.2/include/c++/4.9.2/bits/stl_list.h:387
#9  0x000000000075a996 in vg::Mapper::align_multi_internal(bool, vg::Alignment const&, int, int, int, int, double&, int, std::vector<vg::MaximalExactMatch, std::allocator<vg::MaximalExactMatch> >*) () at src/mapper.cpp:2597
#10 0x000000000075ae8a in vg::Mapper::align_multi(vg::Alignment const&, int, int, int, int) () at src/mapper.cpp:2564
#11 0x000000000049bac9 in std::_Function_handler<void (vg::Alignment&), main_map(int, char**)::{lambda(vg::Alignment&)#5}>::_M_invoke(std::_Any_data const&, vg::Alignment&) ()
    at src/main.cpp:6111
#12 0x000000000078dd4b in vg::fastq_unpaired_for_each_parallel(std::string&, std::function<void (vg::Alignment&)>) [clone ._omp_fn.1] ()
    at /software/hpag/gcc/4.9.2/include/c++/4.9.2/functional:2439
#13 0x00007ffff60bf806 in gomp_thread_start () at /lustre/scratch110/sanger/gt1/build/gcc/gcc-4.9.2-src/libgomp/team.c:117
#14 0x00007ffff7762e9a in start_thread (arg=0x7fffeb70f700) at pthread_create.c:308
#15 0x00007ffff5bd136d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:112
#16 0x0000000000000000 in ?? ()

@ekg
Copy link
Member

ekg commented Feb 13, 2017 via email

@ekg
Copy link
Member

ekg commented Feb 15, 2017

@shilpagarg this may not be quite quite enough--- how do I generate the index pair from the vg? Is it just vg index -x true-yeast-graph.xg -g true-yeast-graph.gcsa -k 16 true-yeast-graph.vg?

@shilpagarg
Copy link
Author

shilpagarg commented Feb 15, 2017 via email

@shilpagarg
Copy link
Author

Here is the gcsa of the graph:

https://transfer.sh/kWSSf/true-yeast-graph-x.gcsa

adamnovak added a commit to adamnovak/vg that referenced this issue Feb 17, 2017
Now you can simplify a Mapping with no position, as long as it doesn't
have a leading deletion. This might fix vgteam#662.
@adamnovak adamnovak self-assigned this Feb 17, 2017
adamnovak added a commit to adamnovak/vg that referenced this issue Feb 21, 2017
Now you can simplify a Mapping with no position, as long as it doesn't
have a leading deletion. This might fix vgteam#662.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants