Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Knative eventing in default cluster setup #177

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Add Knative eventing in default cluster setup #177

merged 2 commits into from
Mar 17, 2021

Conversation

shyamjesal
Copy link
Collaborator

Signed-off-by: Shyam Jesal s.jesalpura@gmail.com

@shyamjesal
Add Knative eventing in default setup
244ef0b 
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
@shyamjesal shyamjesal marked this pull request as draft March 17, 2021 08:29
@shyamjesal shyamjesal linked an issue Mar 17, 2021 that may be closed by this pull request
Support Knative eventing in vHive #164
Closed
ustiugov
ustiugov reviewed Mar 17, 2021
View reviewed changes
scripts/cluster/setup_master_node.sh Outdated
kubectl --namespace istio-system get service istio-ingressgateway

# install knative eventing
kubectl apply --filename https://github.com/knative/eventing/releases/download/v0.21.0/eventing-crds.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make v0.21.0 a variable that is used for the stock serving and eventing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ustiugov
ustiugov reviewed Mar 17, 2021
View reviewed changes
scripts/cluster/setup_master_node.sh Outdated
kubectl apply --filename https://github.com/knative/eventing/releases/download/v0.21.0/eventing-core.yaml

# install a default Channel (messaging) layer
kubectl apply --filename https://github.com/knative/eventing/releases/download/v0.21.0/in-memory-channel.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: need to replace this with Kafka

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added as a comment.

@shyamjesal shyamjesal force-pushed the add-knative-eventing branch 3 times, most recently from ce0909a to e352489 Compare March 17, 2021 12:11
ustiugov
ustiugov requested changes Mar 17, 2021
View reviewed changes
scripts/cluster/setup_master_node.sh Show resolved Hide resolved
scripts/setup_zipkin.sh Show resolved Hide resolved
@shyamjesal shyamjesal force-pushed the add-knative-eventing branch 4 times, most recently from 2f84620 to 882fd01 Compare March 17, 2021 14:07
ustiugov
ustiugov reviewed Mar 17, 2021
View reviewed changes
CHANGELOG.md Outdated
@@ -9,6 +9,7 @@
- Zipkin support added for tracing Knative function call requests. More info [here](./docs/developers_guide.md#Knative-request-tracing)
- added support for MinIO object store. More info [here](./docs/developers_guide.md#MinIO-S3-service)
- Added an automated tail-latency-aware profiler that collects the metrics for [TopDown](https://ieeexplore.ieee.org/document/6844459) characterization from Intel.
- [alpha] Added knative eventing support.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please specify that only their in-memory channel is supported as of now and through integration tests are missing (unless you plan to add an eventing example in this PR). Maybe adding an invocation without validation in this PR is a good idea if it is more or less trivial. If it would take more than 30min, let's postpone it to another PR.

@ustiugov ustiugov added the enhancement New feature or request label Mar 17, 2021
@ustiugov ustiugov added this to the Support function composition milestone Mar 17, 2021
@shyamjesal
fix zipkin CI integration
5166fe8 
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
@ustiugov ustiugov marked this pull request as ready for review March 17, 2021 14:52
@ustiugov ustiugov enabled auto-merge (rebase) March 17, 2021 14:52
@shyamjesal shyamjesal merged commit 952cf1e into master Mar 17, 2021
@shyamjesal shyamjesal deleted the add-knative-eventing branch March 17, 2021 16:13
HermioneKT added a commit that referenced this pull request Jan 31, 2024
@HermioneKT
# This is a combination of 252 commits.
3c6919f 
parent 6674807
author HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800
committer HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800

test

# This is the commit message #157:

test

# This is the commit message #159:

test

# This is the commit message #160:

test

# This is the commit message #161:

test

# This is the commit message #162:

test

# This is the commit message #163:

test

# This is the commit message #164:

tesT

# This is the commit message #165:

test

# This is the commit message #166:

test

# This is the commit message #167:

test

# This is the commit message #168:

test

# This is the commit message #169:

test

# This is the commit message #170:

test

# This is the commit message #171:

Test

# This is the commit message #172:

test

# This is the commit message #173:

test

# This is the commit message #174:

test

# This is the commit message #175:

test

# This is the commit message #176:

test

# This is the commit message #177:

test

# This is the commit message #178:

test

# This is the commit message #179:

test

# This is the commit message #180:

test

# This is the commit message #181:

test

# This is the commit message #182:

test

# This is the commit message #183:

test

# This is the commit message #184:

test

# This is the commit message #185:

test

# This is the commit message #186:

test

# This is the commit message #187:

test

# This is the commit message #188:

test

# This is the commit message #189:

test

# This is the commit message #190:

Test

# This is the commit message #191:

Test

# This is the commit message #192:

test

# This is the commit message #193:

Test

# This is the commit message #194:

test

# This is the commit message #195:

test

# This is the commit message #196:

test

# This is the commit message #197:

test

# This is the commit message #198:

test

# This is the commit message #199:

Test

# This is the commit message #200:

test

# This is the commit message #201:

test

# This is the commit message #202:

Test

# This is the commit message #203:

test

# This is the commit message #204:

test

# This is the commit message #205:

test

# This is the commit message #206:

test

# This is the commit message #207:

test

# This is the commit message #208:

test

# This is the commit message #209:

test

# This is the commit message #210:

test

# This is the commit message #211:

Test

# This is the commit message #212:

test

# This is the commit message #213:

Test

# This is the commit message #214:

Test

# This is the commit message #215:

Test

# This is the commit message #216:

test

# This is the commit message #217:

Test

# This is the commit message #218:

test

# This is the commit message #219:

test

# This is the commit message #220:

test

# This is the commit message #221:

test

# This is the commit message #222:

test

# This is the commit message #223:

test

# This is the commit message #224:

test

# This is the commit message #225:

test

# This is the commit message #226:

test

# This is the commit message #227:

test

# This is the commit message #228:

test

# This is the commit message #229:

Test

# This is the commit message #230:

test

# This is the commit message #231:

test

# This is the commit message #232:

test

# This is the commit message #233:

test

# This is the commit message #234:

Test

# This is the commit message #235:

test

# This is the commit message #236:

test

# This is the commit message #237:

test

# This is the commit message #238:

test

# This is the commit message #239:

test

# This is the commit message #240:

test

# This is the commit message #241:

test

# This is the commit message #242:

test

# This is the commit message #243:

test

# This is the commit message #244:

test

# This is the commit message #245:

test

# This is the commit message #246:

test

# This is the commit message #247:

test

# This is the commit message #248:

test

# This is the commit message #249:

test

# This is the commit message #250:

test

# This is the commit message #251:

test

# This is the commit message #252:

test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov approved these changes

Assignees

@shyamjesal shyamjesal

Labels
enhancement New feature or request
Projects
vHive Roadmap
  
Awaiting triage
Milestone
Support function composition
Development

Successfully merging this pull request may close these issues.

Support Knative eventing in vHive
2 participants
@shyamjesal @ustiugov