Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CI env variables #216

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Refactor CI env variables #216

merged 2 commits into from
Apr 19, 2021

Conversation

ustiugov
Copy link
Member

@ustiugov ustiugov commented Apr 18, 2021 •
edited
Loading

  • move duplicated env variable declarations to the workflow and job levels
  • add job_id to nightly CRI logs to avoid parallel jobs overwrite each other's artifacts

Signed-off-by: Dmitrii Ustiugov dmitrii.ustiugov@epfl.ch

@ustiugov ustiugov added the enhancement New feature or request label Apr 18, 2021
@ustiugov ustiugov force-pushed the refactor_CI_env branch 5 times, most recently from f7a823a to cd404fa Compare April 18, 2021 13:47
@ustiugov
move duplicated env variable declarations to the workflow and job levels
42d32c8 
add job_id to nightly CRI logs

Signed-off-by: Dmitrii Ustiugov <dmitrii.ustiugov@epfl.ch>
shyamjesal
shyamjesal requested changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@shyamjesal shyamjesal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we modify the CTRDLOGDIR variable inside start_onenode_vhive_cluster.sh in order to avoid log rewrites by parallel jobs?

shyamjesal
shyamjesal previously approved these changes Apr 19, 2021
View reviewed changes
@ustiugov
replaced the nightly badge with the CRI badge
d751eb6 
Signed-off-by: Dmitrii Ustiugov <dmitrii.ustiugov@epfl.ch>
@ustiugov ustiugov enabled auto-merge (rebase) April 19, 2021 10:11
@ustiugov ustiugov linked an issue Apr 19, 2021 that may be closed by this pull request
Add vanilla snapshots option to the CRI tests #187
Closed
@ustiugov ustiugov merged commit 4ec90bd into main Apr 19, 2021
@ustiugov ustiugov deleted the refactor_CI_env branch April 19, 2021 11:09
HermioneKT added a commit that referenced this pull request Jan 31, 2024
@HermioneKT
# This is a combination of 252 commits.
3c6919f 
parent 6674807
author HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800
committer HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800

test

# This is the commit message #157:

test

# This is the commit message #159:

test

# This is the commit message #160:

test

# This is the commit message #161:

test

# This is the commit message #162:

test

# This is the commit message #163:

test

# This is the commit message #164:

tesT

# This is the commit message #165:

test

# This is the commit message #166:

test

# This is the commit message #167:

test

# This is the commit message #168:

test

# This is the commit message #169:

test

# This is the commit message #170:

test

# This is the commit message #171:

Test

# This is the commit message #172:

test

# This is the commit message #173:

test

# This is the commit message #174:

test

# This is the commit message #175:

test

# This is the commit message #176:

test

# This is the commit message #177:

test

# This is the commit message #178:

test

# This is the commit message #179:

test

# This is the commit message #180:

test

# This is the commit message #181:

test

# This is the commit message #182:

test

# This is the commit message #183:

test

# This is the commit message #184:

test

# This is the commit message #185:

test

# This is the commit message #186:

test

# This is the commit message #187:

test

# This is the commit message #188:

test

# This is the commit message #189:

test

# This is the commit message #190:

Test

# This is the commit message #191:

Test

# This is the commit message #192:

test

# This is the commit message #193:

Test

# This is the commit message #194:

test

# This is the commit message #195:

test

# This is the commit message #196:

test

# This is the commit message #197:

test

# This is the commit message #198:

test

# This is the commit message #199:

Test

# This is the commit message #200:

test

# This is the commit message #201:

test

# This is the commit message #202:

Test

# This is the commit message #203:

test

# This is the commit message #204:

test

# This is the commit message #205:

test

# This is the commit message #206:

test

# This is the commit message #207:

test

# This is the commit message #208:

test

# This is the commit message #209:

test

# This is the commit message #210:

test

# This is the commit message #211:

Test

# This is the commit message #212:

test

# This is the commit message #213:

Test

# This is the commit message #214:

Test

# This is the commit message #215:

Test

# This is the commit message #216:

test

# This is the commit message #217:

Test

# This is the commit message #218:

test

# This is the commit message #219:

test

# This is the commit message #220:

test

# This is the commit message #221:

test

# This is the commit message #222:

test

# This is the commit message #223:

test

# This is the commit message #224:

test

# This is the commit message #225:

test

# This is the commit message #226:

test

# This is the commit message #227:

test

# This is the commit message #228:

test

# This is the commit message #229:

Test

# This is the commit message #230:

test

# This is the commit message #231:

test

# This is the commit message #232:

test

# This is the commit message #233:

test

# This is the commit message #234:

Test

# This is the commit message #235:

test

# This is the commit message #236:

test

# This is the commit message #237:

test

# This is the commit message #238:

test

# This is the commit message #239:

test

# This is the commit message #240:

test

# This is the commit message #241:

test

# This is the commit message #242:

test

# This is the commit message #243:

test

# This is the commit message #244:

test

# This is the commit message #245:

test

# This is the commit message #246:

test

# This is the commit message #247:

test

# This is the commit message #248:

test

# This is the commit message #249:

test

# This is the commit message #250:

test

# This is the commit message #251:

test

# This is the commit message #252:

test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamjesal shyamjesal shyamjesal approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add vanilla snapshots option to the CRI tests
2 participants
@ustiugov @shyamjesal