Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chained functions serving microbenchmark #250

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Chained functions serving microbenchmark #250

merged 3 commits into from
Jun 11, 2021

Conversation

MBaczun
Copy link
Contributor

@MBaczun MBaczun commented May 26, 2021 •
edited
Loading

Setting up a basic chained serving example, to be used for experimentation with tracing later down the line.

Included:

  • Client -> Producer -> Consumer chain gRPC implementation
  • Dockerised Producer and Consumer
  • Docker-compose for producer and consumer
  • CI for docker-compose benchmarks (easily expandable) on the build_docker_images workflow
  • Knative manifests
  • Knative CI workflow

@MBaczun MBaczun requested a review from ustiugov May 26, 2021 13:31
@MBaczun MBaczun self-assigned this May 26, 2021
ustiugov
ustiugov requested changes May 26, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited by MBaczun
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent start! good job

  • rename to the app to chained-functions-serving instead of producer-consumer
  • add copyrights to all files with a header " and EASE Lab"
  • log to files instead of terminals
  • add protobuf files generation to the test before building the images
  • add a test that invokes the whole chain with Docker in the CI

.github/workflows/build_docker_images.yml Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/Dockerfile Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/Dockerfile Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/client/client.go Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/consumer/consumer.go Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/prodcon/prodcon.proto Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/producer/producer.go Outdated Show resolved Hide resolved
.github/workflows/build_docker_images.yml Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/prodcon/prodcon.proto Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/go.mod Outdated Show resolved Hide resolved
@MBaczun MBaczun changed the title Producer consumer chained serving microbenchmark Chained functions serving microbenchmark May 26, 2021
@ustiugov
Copy link
Member

ustiugov commented Jun 2, 2021

too many minor commits, you need to use git commit --amend with git push --force to coalesce small same-feature commits. you can also use git rebase -i to squash (i.e., fuse few commits into one) interactively.

Avoid merge commits, instead use git rebase.

Merge branch 'producer-consumer-serving' of https://github.com/ease-l…

Please ask @boramalper for further detail on these two issues.

@boramalper boramalper mentioned this pull request Jun 2, 2021
Closed
@MBaczun MBaczun force-pushed the producer-consumer-serving branch 14 times, most recently from 7b72787 to e51c17f Compare June 4, 2021 08:36
ustiugov
ustiugov reviewed Jun 4, 2021
View reviewed changes
.github/workflows/build_docker_images.yml Outdated Show resolved Hide resolved
function-images/tests/producer-consumer/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/uBench_whole_chain.yml Outdated Show resolved Hide resolved
.github/workflows/uBench_whole_chain.yml Outdated Show resolved Hide resolved
@MBaczun MBaczun force-pushed the producer-consumer-serving branch 2 times, most recently from efcc2c6 to d455179 Compare June 4, 2021 08:57
@MBaczun MBaczun force-pushed the producer-consumer-serving branch 6 times, most recently from 4b4b572 to e0d127b Compare June 4, 2021 10:49
@MBaczun MBaczun force-pushed the producer-consumer-serving branch 7 times, most recently from 78b82db to a159830 Compare June 10, 2021 14:38
ustiugov
ustiugov reviewed Jun 10, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove log files

function-images/tests/chained-function-serving/consumer/consumer.go Outdated Show resolved Hide resolved
function-images/tests/chained-function-serving/producer/producer.go Outdated Show resolved Hide resolved
@MBaczun MBaczun requested a review from ustiugov June 10, 2021 15:14
@ustiugov ustiugov enabled auto-merge (rebase) June 10, 2021 16:39
ustiugov
ustiugov requested changes Jun 10, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited by MBaczun
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • correct names
  • sign all commits

.github/workflows/function-composition.yml Outdated Show resolved Hide resolved
.github/workflows/function-composition.yml Outdated Show resolved Hide resolved
.github/workflows/function-composition.yml Outdated Show resolved Hide resolved
.github/workflows/function-composition.yml Outdated Show resolved Hide resolved
.github/workflows/function-composition.yml Outdated Show resolved Hide resolved
.github/workflows/function-composition.yml Outdated Show resolved Hide resolved
ustiugov
ustiugov requested changes Jun 11, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited by MBaczun
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please sign the commit by adding the signature line manually e.g. with rebase interactive
  • add a line to the changelog

Michal M added 2 commits June 11, 2021 08:59
Creates chained serving example w/ Docker
2c4492f 
Adds client, producer, consumer, lite-producer (for testing)

Adds Proto files

Adds docker and docker-compose

Adds docker-compose to the CI.

Signed-off-by: Michal Baczun <s1743497@ed.ac.uk>
Adds knative manifests, adds kn to CI
c460fbf 
Signed-off-by: Michal Baczun <s1743497@ed.ac.uk>
ustiugov
ustiugov requested changes Jun 11, 2021
View reviewed changes
.github/workflows/function-composition.yml Outdated Show resolved Hide resolved
.github/workflows/function-composition.yml Outdated Show resolved Hide resolved
ustiugov
ustiugov requested changes Jun 11, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@MBaczun MBaczun force-pushed the producer-consumer-serving branch 2 times, most recently from 8a69059 to eaae2b0 Compare June 11, 2021 08:08
invoker support, updates ports, workflows, docker
abfd0b5 
Client returns a fatal error if communication with the producer fails
Producer now has lite-producer functionality if the flag is used
Lite producer is removed.
changes producer to work with examples invoker
Updates dockerfile to use target arg
Changes defualt ports
general cleanup
Removes environment variables
adds serving images to CI/CD
updates dependabot
updates workflows to use grpcurl
removes logs

Signed-off-by: Michal Baczun <s1743497@ed.ac.uk>
@MBaczun MBaczun requested a review from ustiugov June 11, 2021 08:39
@ustiugov ustiugov merged commit 38a5ab1 into main Jun 11, 2021
@ustiugov ustiugov deleted the producer-consumer-serving branch June 11, 2021 11:07
HermioneKT added a commit that referenced this pull request Jan 31, 2024
@HermioneKT
# This is a combination of 252 commits.
3c6919f 
parent 6674807
author HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800
committer HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800

test

# This is the commit message #157:

test

# This is the commit message #159:

test

# This is the commit message #160:

test

# This is the commit message #161:

test

# This is the commit message #162:

test

# This is the commit message #163:

test

# This is the commit message #164:

tesT

# This is the commit message #165:

test

# This is the commit message #166:

test

# This is the commit message #167:

test

# This is the commit message #168:

test

# This is the commit message #169:

test

# This is the commit message #170:

test

# This is the commit message #171:

Test

# This is the commit message #172:

test

# This is the commit message #173:

test

# This is the commit message #174:

test

# This is the commit message #175:

test

# This is the commit message #176:

test

# This is the commit message #177:

test

# This is the commit message #178:

test

# This is the commit message #179:

test

# This is the commit message #180:

test

# This is the commit message #181:

test

# This is the commit message #182:

test

# This is the commit message #183:

test

# This is the commit message #184:

test

# This is the commit message #185:

test

# This is the commit message #186:

test

# This is the commit message #187:

test

# This is the commit message #188:

test

# This is the commit message #189:

test

# This is the commit message #190:

Test

# This is the commit message #191:

Test

# This is the commit message #192:

test

# This is the commit message #193:

Test

# This is the commit message #194:

test

# This is the commit message #195:

test

# This is the commit message #196:

test

# This is the commit message #197:

test

# This is the commit message #198:

test

# This is the commit message #199:

Test

# This is the commit message #200:

test

# This is the commit message #201:

test

# This is the commit message #202:

Test

# This is the commit message #203:

test

# This is the commit message #204:

test

# This is the commit message #205:

test

# This is the commit message #206:

test

# This is the commit message #207:

test

# This is the commit message #208:

test

# This is the commit message #209:

test

# This is the commit message #210:

test

# This is the commit message #211:

Test

# This is the commit message #212:

test

# This is the commit message #213:

Test

# This is the commit message #214:

Test

# This is the commit message #215:

Test

# This is the commit message #216:

test

# This is the commit message #217:

Test

# This is the commit message #218:

test

# This is the commit message #219:

test

# This is the commit message #220:

test

# This is the commit message #221:

test

# This is the commit message #222:

test

# This is the commit message #223:

test

# This is the commit message #224:

test

# This is the commit message #225:

test

# This is the commit message #226:

test

# This is the commit message #227:

test

# This is the commit message #228:

test

# This is the commit message #229:

Test

# This is the commit message #230:

test

# This is the commit message #231:

test

# This is the commit message #232:

test

# This is the commit message #233:

test

# This is the commit message #234:

Test

# This is the commit message #235:

test

# This is the commit message #236:

test

# This is the commit message #237:

test

# This is the commit message #238:

test

# This is the commit message #239:

test

# This is the commit message #240:

test

# This is the commit message #241:

test

# This is the commit message #242:

test

# This is the commit message #243:

test

# This is the commit message #244:

test

# This is the commit message #245:

test

# This is the commit message #246:

test

# This is the commit message #247:

test

# This is the commit message #248:

test

# This is the commit message #249:

test

# This is the commit message #250:

test

# This is the commit message #251:

test

# This is the commit message #252:

test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov approved these changes

Assignees

@MBaczun MBaczun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MBaczun @ustiugov