Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade firecracker-containerd binaries with containerd 1.5.2 #227

Merged
merged 8 commits into from
Jun 18, 2021
Merged

Upgrade firecracker-containerd binaries with containerd 1.5.2 #227

merged 8 commits into from
Jun 18, 2021

Conversation

plamenmpetrov
Copy link
Collaborator

@plamenmpetrov plamenmpetrov commented May 3, 2021 •
edited by ustiugov
Loading

  • upgrade rootfs and runtime binary to v0.24
  • added artifact to integ test
  • change format of vmID
  • update firecracker-containerd binaries
  • clean up shim sockets
  • cleaned go.sum
  • add upgrade to CHANGELOG.md

Signed-off-by: Plamen Petrov plamb0brt@gmail.com

@plamenmpetrov plamenmpetrov force-pushed the upgrade-ctrd-0.24 branch 2 times, most recently from 11d0980 to df09f43 Compare May 20, 2021 13:55
@plamenmpetrov plamenmpetrov force-pushed the upgrade-ctrd-0.24 branch 5 times, most recently from bebb1fa to f554d1a Compare May 28, 2021 19:49
ustiugov
ustiugov requested changes May 28, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but let's pull the latest changes for firecracker-containerd. particularly, we are interested in containerd 1.5

@plamenmpetrov plamenmpetrov force-pushed the upgrade-ctrd-0.24 branch 4 times, most recently from e54e881 to 557d6d3 Compare May 29, 2021 11:19
ustiugov
ustiugov reviewed May 29, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have to fix the grpc version? why?

ctriface/go.mod Outdated Show resolved Hide resolved
scripts/clean_fcctr.sh Show resolved Hide resolved
@ustiugov ustiugov changed the title Upgrade firecracker-containerd binaries with v0.24 version of Firecracker Upgrade firecracker-containerd binaries with containerd 1.5.2 May 29, 2021
@ustiugov ustiugov added the dependencies Pull requests that update a dependency file label May 29, 2021
@ustiugov ustiugov added this to In progress in vHive Roadmap May 29, 2021
ustiugov
ustiugov reviewed Jun 15, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
scripts/clean_fcctr.sh Show resolved Hide resolved
@ustiugov
Copy link
Member

Rebase when ready and let's merge it

@ustiugov
Copy link
Member

please add a note to CHANGELOG.md in the Changed section of unreleased

@plamenmpetrov
added ctrd v0.24 binaries
d9f14a0 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
upgrade rootfs and runtime binary to v0.24
6ba28d3 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
added artifact to integ test
53f9857 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
change format of vmID
9181133 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
update fccd bins
2d7e4b6 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
clean up shim sockets and go.sum
d4bd683 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
update CHANGELOG and fccd dependency
9b7b783 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@plamenmpetrov
upgrade fccd binaries and rootfs to ctrd 1.5.2
b31b5a0 
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
@ustiugov ustiugov merged commit dfa0d40 into main Jun 18, 2021
vHive Roadmap automation moved this from In progress to Done Jun 18, 2021
@ustiugov ustiugov deleted the upgrade-ctrd-0.24 branch June 18, 2021 21:10
HermioneKT added a commit that referenced this pull request Jan 31, 2024
@HermioneKT
# This is a combination of 252 commits.
3c6919f 
parent 6674807
author HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800
committer HermioneKT <hermionegrangerkt@gmail.com> 1706694164 +0800

test

# This is the commit message #157:

test

# This is the commit message #159:

test

# This is the commit message #160:

test

# This is the commit message #161:

test

# This is the commit message #162:

test

# This is the commit message #163:

test

# This is the commit message #164:

tesT

# This is the commit message #165:

test

# This is the commit message #166:

test

# This is the commit message #167:

test

# This is the commit message #168:

test

# This is the commit message #169:

test

# This is the commit message #170:

test

# This is the commit message #171:

Test

# This is the commit message #172:

test

# This is the commit message #173:

test

# This is the commit message #174:

test

# This is the commit message #175:

test

# This is the commit message #176:

test

# This is the commit message #177:

test

# This is the commit message #178:

test

# This is the commit message #179:

test

# This is the commit message #180:

test

# This is the commit message #181:

test

# This is the commit message #182:

test

# This is the commit message #183:

test

# This is the commit message #184:

test

# This is the commit message #185:

test

# This is the commit message #186:

test

# This is the commit message #187:

test

# This is the commit message #188:

test

# This is the commit message #189:

test

# This is the commit message #190:

Test

# This is the commit message #191:

Test

# This is the commit message #192:

test

# This is the commit message #193:

Test

# This is the commit message #194:

test

# This is the commit message #195:

test

# This is the commit message #196:

test

# This is the commit message #197:

test

# This is the commit message #198:

test

# This is the commit message #199:

Test

# This is the commit message #200:

test

# This is the commit message #201:

test

# This is the commit message #202:

Test

# This is the commit message #203:

test

# This is the commit message #204:

test

# This is the commit message #205:

test

# This is the commit message #206:

test

# This is the commit message #207:

test

# This is the commit message #208:

test

# This is the commit message #209:

test

# This is the commit message #210:

test

# This is the commit message #211:

Test

# This is the commit message #212:

test

# This is the commit message #213:

Test

# This is the commit message #214:

Test

# This is the commit message #215:

Test

# This is the commit message #216:

test

# This is the commit message #217:

Test

# This is the commit message #218:

test

# This is the commit message #219:

test

# This is the commit message #220:

test

# This is the commit message #221:

test

# This is the commit message #222:

test

# This is the commit message #223:

test

# This is the commit message #224:

test

# This is the commit message #225:

test

# This is the commit message #226:

test

# This is the commit message #227:

test

# This is the commit message #228:

test

# This is the commit message #229:

Test

# This is the commit message #230:

test

# This is the commit message #231:

test

# This is the commit message #232:

test

# This is the commit message #233:

test

# This is the commit message #234:

Test

# This is the commit message #235:

test

# This is the commit message #236:

test

# This is the commit message #237:

test

# This is the commit message #238:

test

# This is the commit message #239:

test

# This is the commit message #240:

test

# This is the commit message #241:

test

# This is the commit message #242:

test

# This is the commit message #243:

test

# This is the commit message #244:

test

# This is the commit message #245:

test

# This is the commit message #246:

test

# This is the commit message #247:

test

# This is the commit message #248:

test

# This is the commit message #249:

test

# This is the commit message #250:

test

# This is the commit message #251:

test

# This is the commit message #252:

test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov approved these changes

@shyamjesal shyamjesal Awaiting requested review from shyamjesal

Assignees

@plamenmpetrov plamenmpetrov

Labels
dependencies Pull requests that update a dependency file
Projects
vHive Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@plamenmpetrov @ustiugov