Video bench min scale #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ustiugov
previously approved these changes
Jul 28, 2021
|
please force push to this because checks seem to be stuck (must be a GH problem) |
ustiugov
requested changes
Jul 29, 2021
There was a problem hiding this comment.
- please also set the hard concurrency limit to 1 https://knative.dev/docs/serving/autoscaling/concurrency/
- instead of minScale, please set the fixed scale (or define both min and max). we don't want the autoscaler to kick in
function-images/tests/video-analytics/knative_yamls/xdt/service-recog.yaml
Show resolved
Hide resolved
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
shyamjesal
force-pushed
the
video-bench-min-scale
branch
from
a2c7ed9
to
4071269
Compare
ustiugov
previously approved these changes
Jul 30, 2021
shyamjesal
force-pushed
the
video-bench-min-scale
branch
2 times, most recently
from
1ce5c03
to
b20ca4b
Compare
Signed-off-by: Shyam Jesal <s.jesalpura@gmail.com>
shyamjesal
force-pushed
the
video-bench-min-scale
branch
from
b20ca4b
to
35ed77c
Compare
ustiugov
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONCURRENT_RECOGto infer frames in parallel