Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add chinese #6

Merged
merged 2 commits into from
Mar 26, 2018
Merged

add chinese #6

merged 2 commits into from
Mar 26, 2018

Conversation

ZhangHanDong
Copy link
Contributor

add chinese mod

lilydjwg
lilydjwg reviewed Mar 26, 2018
View reviewed changes
src/languages/chinese.rs Outdated
fn ago(&self) -> &'static str { "之前" }
fn get_word(&self, tu: TimeUnit, x: u64) -> &'static str {
use TimeUnit::*;
if x == 1 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to branch on x == 1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved, thanks

@vi vi merged commit 4ea2029 into vi:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilydjwg lilydjwg lilydjwg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZhangHanDong @lilydjwg @vi