Lotus #686
Closed
Lotus #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing key-codes to match latest QMK iteration, some options are moved to .JSON
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Simplified OLED, cleaned up keymap
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
… Lotus # Conflicts: # keyboards/tweetydabird/lotus58/info.json # keyboards/tweetydabird/lotus58/keymaps/vial/rules.mk
… Lotus # Conflicts: # keyboards/tweetydabird/lotus58/info.json # keyboards/tweetydabird/lotus58/keymaps/vial/rules.mk
lesshonor
reviewed
Mar 6, 2024
| @@ -7,15 +7,15 @@ VIAL_ENABLE = yes | |||
| ENCODER_MAP_ENABLE = yes | |||
|
|
|||
| # Reduce size on atmega32u4 | |||
| ifeq ($(strip $(CONVERT_TO)), ) | |||
| ifeq ($(strip $(MCU)), atmega32u4) | |||
There was a problem hiding this comment.
Not sure why this change is being reverted. It will result in these features being disabled (and LTO turned on) by default on all Vial builds (see #684).
There was a problem hiding this comment.
Mostly because I had a disagreement with the Git client. We are working it out.
|
Closing as no updates over a month |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rp2040_ce and minor updates