[APP-3496] New install script and linting #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ale7714
approved these changes
Feb 12, 2024
| @@ -3,8 +3,14 @@ | |||
| # This script installs viam-agent. It is intended to be run directly from a download, with a command such as: | |||
| # sudo /bin/sh -c "$(curl -fsSL https://storage.googleapis.com/packages.viam.com/apps/viam-agent/install.sh)" | |||
|
|
|||
| # The preferred command should be copy/pasted from the robot's setup tab on app.viam.com | |||
| # It should auto-generate a command in the following format (with key/id info filled in) | |||
| # sudo /bin/sh -c "VIAM_API_KEY_ID=<KEYID> VIAM_API_KEY=<KEY> VIAM_PART_ID=<PARTID>; $(curl -fsSL https://storage.googleapis.com/packages.viam.com/apps/viam-agent/install.sh)" | |||
There was a problem hiding this comment.
This is future proofing the docs. But we still need to change the cloud app right?
There was a problem hiding this comment.
Correct, App still needs to implement. This was a comment saying what app should do. The actual README explains it as-currently-is however.
|
|
||
| [Service] | ||
| Type=exec | ||
| Restart=always | ||
| RestartSec=1 |
There was a problem hiding this comment.
OOC did you find 1s to be too short of an interval?
There was a problem hiding this comment.
1s is always too fast, IMHO. If you're trying to debug an issue, having the log flooded with failures every second is annoying, and there's nothing 4 extra seconds is going to ruin, as this shouldn't have to restart often at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lints the code, and significantly updates the install scripting to support provisioning better.