-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-6132 - [RC] [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 18, 2024
nicksanford
force-pushed
the
RSDK-6132
branch
from
January 22, 2024 14:55
72301a3
to
3a53e8a
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 22, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 22, 2024
nicksanford
commented
Jan 22, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 22, 2024
nicksanford
commented
Jan 22, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 22, 2024
nicksanford
commented
Jan 22, 2024
nicksanford
force-pushed
the
RSDK-6132
branch
from
January 23, 2024 16:26
bf72bfe
to
ca758df
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 23, 2024
nicksanford
changed the title
RSDK-6132
RSDK-6132 - [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap
Jan 23, 2024
nicksanford
changed the title
RSDK-6132 - [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap
RSDK-6132 - [RC] [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap
Jan 23, 2024
nfranczak
approved these changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This was referenced Jan 23, 2024
Merged
micheal-parks
approved these changes
Jan 24, 2024
nicksanford
force-pushed
the
RSDK-6132
branch
from
January 24, 2024 20:04
055a525
to
8b7caee
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Compatible with viam-server version
v0.19.0
+Follow up PRs from feedback:
viamrobotics/prime#470
#3474
Kapture.2024-01-19.at.17.07.37.mp4
Manually tested both on fake slam on a mac & with real hardware on a viam rover.