Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-6132 - [RC] [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap #3450

Merged
merged 12 commits into from
Jan 24, 2024
Merged

RSDK-6132 - [RC] [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap #3450

merged 12 commits into from
Jan 24, 2024

Conversation

nicksanford
Copy link
Member

@nicksanford nicksanford commented Jan 18, 2024 •
edited
Loading

Ticket

Compatible with viam-server version v0.19.0+

  1. Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap
  2. Change the SLAM RC card button to call motion.StopPlan
  3. Render the motion plan path on the slam RC card
  4. Support rendering & stopping plans initiated from clients other than the RC card (or other RC card instances).

Follow up PRs from feedback:
viamrobotics/prime#470
#3474

Kapture.2024-01-19.at.17.07.37.mp4

Manually tested both on fake slam on a mac & with real hardware on a viam rover.

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 18, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 22, 2024
@nicksanford nicksanford marked this pull request as ready for review January 22, 2024 15:22
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 22, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 22, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 22, 2024
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 23, 2024
@nicksanford nicksanford changed the title RSDK-6132 RSDK-6132 - [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap Jan 23, 2024
@nicksanford nicksanford changed the title RSDK-6132 - [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap RSDK-6132 - [RC] [Breaking] Change the SLAM RC card to call motion.MoveOnMapNew rather than motion.MoveOnMap Jan 23, 2024
nfranczak
nfranczak approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@nfranczak nfranczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

This was referenced Jan 23, 2024
Merged
Merged
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Jan 24, 2024
@nicksanford nicksanford merged commit 7855879 into viamrobotics:main Jan 24, 2024
16 checks passed
@nicksanford nicksanford mentioned this pull request Jan 24, 2024
Merged
@nicksanford nicksanford mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanlookpotts ethanlookpotts ethanlookpotts left review comments

@nfranczak nfranczak nfranczak approved these changes

@micheal-parks micheal-parks micheal-parks approved these changes

Assignees
No one assigned
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicksanford @ethanlookpotts @nfranczak @micheal-parks @viambot