Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exception when __merge__ uses an invalid yaml #570

Merged
merged 5 commits into from
Oct 13, 2023

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Oct 12, 2023

Throw a clean exception instead of a stacktrace
Handle same issue during dependency resolution for reading config yamls

Describe your changes

Issue ticket number and link

Closes #539

Checklist before requesting a review

  • I have performed a self-review of my code

  • Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • Relevant unit tests have been added

Throw a clean exception instead of a stacktrace
Handle same issue during dependency resolution for reading config yamls
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...in/scala/io/viash/exceptions/ConfigException.scala 100.00% <100.00%> (ø)
...in/scala/io/viash/helpers/DependencyResolver.scala 88.37% <100.00%> (ø)
...c/main/scala/io/viash/helpers/circe/RichJson.scala 94.62% <100.00%> (+1.29%) ⬆️

📢 Thoughts on this report? Let us know!.

Create a new exception type inheriting AbstractConfigException
@Grifs Grifs requested a review from rcannood October 12, 2023 13:05
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@Grifs Grifs merged commit 7f1cf9b into develop Oct 13, 2023
9 checks passed
@Grifs Grifs deleted the fix/merge_invalid_yaml branch October 13, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants