Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependencies of dependencies resolving failing #701

Merged
merged 6 commits into from
May 14, 2024

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented May 7, 2024

the schema sanitation removed 'writtenPath' that was previously used add .build_info.dependencies

Describe your changes

Related issue(s)

Closes #700

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

Grifs added 2 commits May 7, 2024 19:27
the schema sanitation removed 'writtenPath' that was previously used
add .build_info.dependencies
@Grifs
Copy link
Collaborator Author

Grifs commented May 7, 2024

We need to change the test in src/test/scala/io/viash/config/dependencies/Dependency.scala line 328 back to vsh://hendrik/dependency_test2@main_build before merging and update the repository with a rebuilt version
Code is ok now.

@Grifs Grifs requested a review from rcannood May 8, 2024 06:12
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Grifs Grifs merged commit 2d2addc into develop May 14, 2024
7 checks passed
@Grifs Grifs deleted the fix/dependency_resolving branch May 14, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants