Convert Waitable from struct to pure template to avoid heap closures. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to drop 2.070.0 support to sidestep those linker errors. |
|
Hitting DigitalMars/optlink#18 here. Since issues like these often happen in a seemingly random fashion, I'm inclined to add the Optlink test runs to |
s-ludwig
force-pushed
the
nogc_async
branch
2 times, most recently
from
7381a68
to
b06d066
Compare
|
This also leads to 20% performance improvement for the bench-dummy-http-server example alone. |
Also fixes a case where ThreadLocalWaiter.emitSingle overlaps a call to .emit.
s-ludwig
force-pushed
the
nogc_async
branch
from
f437f5a
to
9fe9783
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first profiling run showed that every call to
asyncAwaitproduced three to four heap closures, due to the way the different callbacks were wrapped. This change eliminates all of these to make room for more performance tuning.