New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timeout non-zero verification - fixes #776 #781

Merged
merged 1 commit into from Aug 13, 2014

Conversation

Projects
None yet
3 participants
@etcimon
Contributor

etcimon commented Aug 13, 2014

The pubsub listener was making the bstop call wait forever, because it was never listening in the first place: the 0 second Duration timeout was being triggered, rather than being considered as a "no timeout" value.

@Extrawurst

This comment has been minimized.

Show comment
Hide comment
@Extrawurst

Extrawurst Aug 13, 2014

Contributor

looks good to me, @s-ludwig can you tag it after merging ?

Contributor

Extrawurst commented Aug 13, 2014

looks good to me, @s-ludwig can you tag it after merging ?

@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 13, 2014

Member

@Extrawurst: Will do.

Member

s-ludwig commented Aug 13, 2014

@Extrawurst: Will do.

Added timeout non-zero verification - fixes #776
Quick fix

Removed RedisDebug version for faster travis builds

Remove debug artifacts
@s-ludwig

This comment has been minimized.

Show comment
Hide comment
@s-ludwig

s-ludwig Aug 13, 2014

Member

Thanks @etcimon! Hopefully Travis is also reliable again now.

Member

s-ludwig commented Aug 13, 2014

Thanks @etcimon! Hopefully Travis is also reliable again now.

s-ludwig added a commit that referenced this pull request Aug 13, 2014

Merge pull request #781 from etcimon/redis-pubsub-fix
Add non-zero timeout verification. Fixes #776.

Also removes the RedisDebug version from the Redis integration test to sidestep Travis CI woes.

@s-ludwig s-ludwig merged commit 73884b4 into vibe-d:master Aug 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@etcimon etcimon deleted the etcimon:redis-pubsub-fix branch Aug 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment