Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix: PR not getting detected - no entry in database #54

Merged
merged 7 commits into from
Oct 30, 2023
Merged

bug fix: PR not getting detected - no entry in database #54

merged 7 commits into from
Oct 30, 2023

Conversation

avikalpg
Copy link
Member

@avikalpg avikalpg commented Oct 30, 2023 •
edited
Loading

SOLUTION: There was a key collision in the sled database between the pr_info objects and the review objects.

Please check the action items covered in the PR -

  • Build is running
  • Eventing is functional and tested
  • Unit or integration tests added and running
  • Manual QA

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@avikalpg avikalpg merged commit 6836c1e into tr/ablejobs Oct 30, 2023
2 checks passed
@avikalpg avikalpg deleted the akg/bug_fix_ablejobs branch October 30, 2023 15:39
MuskanPaliwal
MuskanPaliwal reviewed Oct 30, 2023
View reviewed changes
vibi-dpu/src/pubsub/listener.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove the process_install_callback function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not being used. Tapish said that you have found an alternate way of doing what it does.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nahi, although abhi for this PR, this might not be used since we have only bitbucket specific thing here but once we add github code as well then this will be the modularised function.

avikalpg added a commit that referenced this pull request Oct 31, 2023
@tapishr @avikalpg @MuskanPaliwal
Tr/ablejobs (#46)
9da8060 
* fix keys in webhook data parsing

* bug fix: flow in webhook callback didn't run process_review on pr update, and didn't run update-pr-in-db on creation

* 1. bug fix: pubsub webhook message control flow corrected.
2. removed duplicated function (save and update pr_info functions were doing the same thing)

* bug fix: PR not getting detected - no entry in database (#54)

* bug fix: removed IVec of value while inserting pr_info

* bug fix: database key changed for PR-info to resolve key collision.

---------

Co-authored-by: Avikalp Kumar Gupta <avikalpgupta@gmail.com>
Co-authored-by: Avikalp Kumar Gupta <avikalpg@users.noreply.github.com>
Co-authored-by: Muskan Paliwal <muskan10112002@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuskanPaliwal MuskanPaliwal MuskanPaliwal left review comments

@tapishr tapishr Awaiting requested review from tapishr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avikalpg @MuskanPaliwal