Scope modules created by defparams
to defining module namespace
#24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue with calling
defparams
with the same param schema name in different controllers. This PR makes doing so possible, which I think is convenient because needing to fully type out a unique name for every parameter schema seems needlessly restrictive (especially in a large app with many resources/controllers).This PR allows for the following usage, which previously wouldn't compile, because both controllers would try to create a
Params.CreateParams
module:Now the
defparams
line in each controller will defineParams.MyApp.UserController.CreateParams
andParams.MyApp.OrganizationController.CreateParams
modules, respectively.Feedback appreciated, thanks for the great project.