Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds compatibility with Ecto 3.0 #29

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Adds compatibility with Ecto 3.0 #29

merged 1 commit into from
Nov 8, 2018

Conversation

lasseebert
Copy link
Contributor

  • Can now use Ecto ~> 2.0 or ~> 3.0
  • Changed to use atoms as keys in tests to fix warnings
  • Clean mix.lock, which also cleaned old dependencies that are no longer
    used.

I also tested this in my own project where Params is used.

* Can now use Ecto ~> 2.0 or ~> 3.0
* Changed to use atoms as keys in tests to fix warnings
* Clean mix.lock, which also cleaned old dependencies that are no longer
used.
@lasseebert lasseebert requested a review from vic November 8, 2018 09:46
@vic vic merged commit db0173d into master Nov 8, 2018
@doughsay
Copy link

doughsay commented Nov 9, 2018

Looking forward to this! Can we get a new release soon?

@lasseebert lasseebert deleted the ecto_3_0 branch November 22, 2018 09:36
@tschmittni
Copy link

Thank you, a new release with this change would be great!

@doughsay
Copy link

doughsay commented Jan 5, 2019

@vic thanks for merging, but we're still waiting on a new release to Hex. This dependency is the last one I'm waiting on before I can upgrade my project to ecto 3.

@vic
Copy link
Owner

vic commented Jan 7, 2019

@doughsay sorry for the delay, just published 2.0.6.

@lasseebert
Copy link
Contributor Author

@vic Thanks :)

Btw. the latest (previous) release on hex is 2.1.0, so perhaps this should be bumped to 2.1.1?

@vic
Copy link
Owner

vic commented Jan 7, 2019

Oh really ?? haha, will fix that right now !

Thanks for the heads-up, @lasseebert 👍

@lasseebert
Copy link
Contributor Author

Awesome, thanks 🙂

@doughsay
Copy link

doughsay commented Jan 7, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants