Avoid recursion #380
Merged
Avoid recursion #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BENCHMARK RESULTS (AUTOGENERATED)
|
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| Subscribe empty callbacks to empty observable | 704.46 ns | 0.67 ns | 0.74 ns | 0.90 |
| Subscribe empty callbacks to empty observable via pipe operator | 705.26 ns | 0.67 ns | 0.67 ns | 1.00 |
Sources
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| from array of 1 - create + subscribe + immediate | 1810.89 ns | 0.33 ns | 0.33 ns | 1.00 |
| from array of 1 - create + subscribe + current_thread | 2641.08 ns | 6.03 ns | 6.02 ns | 1.00 |
| concat_as_source of just(1 immediate) create + subscribe | 5532.54 ns | 0.33 ns | 0.33 ns | 1.00 |
Schedulers
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| immediate scheduler create worker + schedule | 731.42 ns | 0.67 ns | 0.67 ns | 1.00 |
| current_thread scheduler create worker + schedule | 889.45 ns | 5.37 ns | 5.37 ns | 1.00 |
| current_thread scheduler create worker + schedule + recursive schedule | 1986.42 ns | 80.49 ns | 81.22 ns | 0.99 |
Combining Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create(create(1), create(1)) + merge() + subscribe | 4470.94 ns | 215.24 ns | 215.23 ns | 1.00 |
| create(1) + merge_with(create(2)) + subscribe | 7027.41 ns | 219.86 ns | 216.41 ns | 1.02 |
Conditional Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+take_while(false)+subscribe | 896.24 ns | - | - | 0.00 |
| create+take_while(true)+subscribe | 855.23 ns | 0.33 ns | 0.33 ns | 1.00 |
Transforming Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+map(v*2)+subscribe | 850.01 ns | 0.33 ns | 0.33 ns | 1.00 |
| create+scan(10, std::plus)+subscribe | 1015.82 ns | 0.33 ns | 0.33 ns | 1.00 |
| create+flat_map(just(v*2))+subscribe | 3262.92 ns | 171.98 ns | 171.19 ns | 1.00 |
Filtering Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+take(1)+subscribe | 1437.14 ns | 0.33 ns | 0.33 ns | 1.00 |
| create+filter(true)+subscribe | 850.20 ns | 0.33 ns | 0.33 ns | 1.00 |
| create(1,2)+skip(1)+subscribe | 1229.54 ns | 0.33 ns | 0.33 ns | 1.00 |
| create(1,1,2)+distinct_until_changed()+subscribe | 860.38 ns | 0.33 ns | 0.33 ns | 1.00 |
Utility Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create(1)+subscribe_on(immediate)+subscribe | 3139.59 ns | 0.33 ns | 0.33 ns | 1.00 |
ci-macos
General
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| Subscribe empty callbacks to empty observable | 1120.07 ns | 0.56 ns | 0.59 ns | 0.94 |
| Subscribe empty callbacks to empty observable via pipe operator | 1106.12 ns | 0.56 ns | 0.57 ns | 0.98 |
Sources
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| from array of 1 - create + subscribe + immediate | 2402.42 ns | 0.45 ns | 0.47 ns | 0.95 |
| from array of 1 - create + subscribe + current_thread | 2883.03 ns | 8.14 ns | 9.08 ns | 0.90 |
| concat_as_source of just(1 immediate) create + subscribe | 6854.28 ns | 0.28 ns | 0.30 ns | 0.92 |
Schedulers
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| immediate scheduler create worker + schedule | 1022.96 ns | 0.56 ns | 0.57 ns | 0.98 |
| current_thread scheduler create worker + schedule | 1279.66 ns | 8.63 ns | 9.97 ns | 0.87 |
| current_thread scheduler create worker + schedule + recursive schedule | 2331.40 ns | 151.03 ns | 787.30 ns | 0.19 |
Combining Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create(create(1), create(1)) + merge() + subscribe | 3932.85 ns | 363.29 ns | 387.31 ns | 0.94 |
| create(1) + merge_with(create(2)) + subscribe | 6672.06 ns | 371.18 ns | 378.60 ns | 0.98 |
Conditional Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+take_while(false)+subscribe | 1177.41 ns | - | - | 0.00 |
| create+take_while(true)+subscribe | 1130.29 ns | 0.28 ns | 0.28 ns | 0.99 |
Transforming Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+map(v*2)+subscribe | 1117.59 ns | 0.28 ns | 0.28 ns | 0.99 |
| create+scan(10, std::plus)+subscribe | 1393.97 ns | 0.54 ns | 0.56 ns | 0.97 |
| create+flat_map(just(v*2))+subscribe | 3234.11 ns | 344.79 ns | 324.10 ns | 1.06 |
Filtering Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+take(1)+subscribe | 1947.94 ns | 0.27 ns | 0.28 ns | 0.96 |
| create+filter(true)+subscribe | 1109.80 ns | 0.27 ns | 0.28 ns | 0.97 |
| create(1,2)+skip(1)+subscribe | 1780.75 ns | 0.27 ns | 0.29 ns | 0.95 |
| create(1,1,2)+distinct_until_changed()+subscribe | 1122.20 ns | 0.56 ns | 0.56 ns | 1.00 |
Utility Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create(1)+subscribe_on(immediate)+subscribe | 3517.80 ns | 0.27 ns | 0.28 ns | 0.97 |
ci-ubuntu-clang
General
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| Subscribe empty callbacks to empty observable | 333.64 ns | 0.80 ns | 0.80 ns | 1.00 |
| Subscribe empty callbacks to empty observable via pipe operator | 341.01 ns | 0.60 ns | 1.21 ns | 0.50 |
Sources
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| from array of 1 - create + subscribe + immediate | 734.29 ns | 0.41 ns | 0.45 ns | 0.91 |
| from array of 1 - create + subscribe + current_thread | 1053.48 ns | 4.42 ns | 5.32 ns | 0.83 |
| concat_as_source of just(1 immediate) create + subscribe | 2525.28 ns | 0.40 ns | 0.40 ns | 1.00 |
Schedulers
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| immediate scheduler create worker + schedule | 258.28 ns | 0.80 ns | 1.20 ns | 0.67 |
| current_thread scheduler create worker + schedule | 387.85 ns | 4.05 ns | 5.21 ns | 0.78 |
| current_thread scheduler create worker + schedule + recursive schedule | 831.87 ns | 67.13 ns | 79.96 ns | 0.84 |
Combining Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create(create(1), create(1)) + merge() + subscribe | 2130.02 ns | 107.69 ns | 142.46 ns | 0.76 |
| create(1) + merge_with(create(2)) + subscribe | 3402.93 ns | 104.33 ns | 134.00 ns | 0.78 |
Conditional Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+take_while(false)+subscribe | 390.95 ns | - | - | 0.00 |
| create+take_while(true)+subscribe | 363.48 ns | 0.40 ns | 0.40 ns | 1.00 |
Transforming Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+map(v*2)+subscribe | 368.45 ns | 0.40 ns | 0.40 ns | 1.00 |
| create+scan(10, std::plus)+subscribe | 453.33 ns | 0.40 ns | 0.81 ns | 0.50 |
| create+flat_map(just(v*2))+subscribe | 1637.10 ns | 88.12 ns | 115.90 ns | 0.76 |
Filtering Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+take(1)+subscribe | 638.66 ns | 0.40 ns | 0.40 ns | 0.99 |
| create+filter(true)+subscribe | 366.13 ns | 0.40 ns | 0.40 ns | 1.00 |
| create(1,2)+skip(1)+subscribe | 571.95 ns | 0.40 ns | 0.41 ns | 0.98 |
| create(1,1,2)+distinct_until_changed()+subscribe | 384.11 ns | 0.40 ns | 0.80 ns | 0.50 |
Utility Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create(1)+subscribe_on(immediate)+subscribe | 1774.62 ns | 0.40 ns | 0.40 ns | 1.00 |
ci-windows
General
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| Subscribe empty callbacks to empty observable | 3612.90 ns | 3.17 ns | 2.39 ns | 1.33 |
| Subscribe empty callbacks to empty observable via pipe operator | 4349.33 ns | 10.65 ns | 2.37 ns | 4.49 |
Sources
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| from array of 1 - create + subscribe + immediate | 12372.04 ns | 23.01 ns | 9.25 ns | 2.49 |
| from array of 1 - create + subscribe + current_thread | 12293.55 ns | 60.66 ns | 29.98 ns | 2.02 |
| concat_as_source of just(1 immediate) create + subscribe | 11050.00 ns | 53.08 ns | 14.66 ns | 3.62 |
Schedulers
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| immediate scheduler create worker + schedule | 2116.43 ns | 5.23 ns | 5.40 ns | 0.97 |
| current_thread scheduler create worker + schedule | 4690.84 ns | 40.27 ns | 13.49 ns | 2.98 |
| current_thread scheduler create worker + schedule + recursive schedule | 3061.00 ns | 2509.69 ns | 163.91 ns | 15.31 |
Combining Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create(create(1), create(1)) + merge() + subscribe | 5543.21 ns | 369.93 ns | 507.52 ns | 0.73 |
| create(1) + merge_with(create(2)) + subscribe | 8768.55 ns | 366.27 ns | 484.17 ns | 0.76 |
Conditional Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+take_while(false)+subscribe | 1442.51 ns | 4.09 ns | 5.25 ns | 0.78 |
| create+take_while(true)+subscribe | 1331.40 ns | 5.42 ns | 6.91 ns | 0.78 |
Transforming Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+map(v*2)+subscribe | 16505.71 ns | 50.30 ns | 6.94 ns | 7.24 |
| create+scan(10, std::plus)+subscribe | 16763.49 ns | 56.54 ns | 10.71 ns | 5.28 |
| create+flat_map(just(v*2))+subscribe | 9840.00 ns | 5381.84 ns | 382.08 ns | 14.09 |
Filtering Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create+take(1)+subscribe | 2417.77 ns | 7.53 ns | 9.30 ns | 0.81 |
| create+filter(true)+subscribe | 1340.51 ns | 6.44 ns | 7.41 ns | 0.87 |
| create(1,2)+skip(1)+subscribe | 2122.95 ns | 7.26 ns | 8.52 ns | 0.85 |
| create(1,1,2)+distinct_until_changed()+subscribe | 1369.89 ns | 14.77 ns | 18.12 ns | 0.82 |
Utility Operators
| name | rxcpp | rpp | prev rpp | ratio |
|---|---|---|---|---|
| create(1)+subscribe_on(immediate)+subscribe | 4748.83 ns | 11.60 ns | 14.31 ns | 0.81 |
Codecov Report
@@ Coverage Diff @@
## v2 #380 +/- ##
==========================================
- Coverage 99.14% 98.51% -0.64%
==========================================
Files 38 40 +2
Lines 820 807 -13
==========================================
- Hits 813 795 -18
- Misses 7 12 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison on my machines:
objdump:
v2
avoid_recursion