Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/bills-tab-home #268

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Conversation

daanvanberkel
Copy link
Contributor

@daanvanberkel daanvanberkel commented Apr 10, 2024

Add tab for bills on homescreen

Summary
I added an extra tab on the home screen to view the bills for the selected period. Including a progress bar to show how much still must be paid for the bills.

@victorbalssa victorbalssa self-requested a review April 10, 2024 17:32
@victorbalssa
Copy link
Owner

Thank you @daanvanberkel!
I will review it 👍🏻

Copy link
Owner

@victorbalssa victorbalssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! 👀

Thank you for following the current structure and custom view components 👍🏻

Just 2 comments to fix edge cases, and I can send it to OTA.

src/components/Screens/HomeScreen.tsx Outdated Show resolved Hide resolved
src/components/Screens/HomeScreen.tsx Outdated Show resolved Hide resolved
@victorbalssa victorbalssa added the enhancement New feature or request label Apr 11, 2024
@victorbalssa victorbalssa added this to the 0.13.2 milestone Apr 11, 2024
@victorbalssa victorbalssa linked an issue Apr 11, 2024 that may be closed by this pull request
@victorbalssa victorbalssa changed the title Add tab for bills on homescreen feature/bills-tab-home Apr 11, 2024
@daanvanberkel daanvanberkel removed their assignment Apr 11, 2024
@daanvanberkel
Copy link
Contributor Author

Hi @victorbalssa, thanks for the review! I fixed your comments 😄

Copy link
Owner

@victorbalssa victorbalssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @daanvanberkel, approved.

@victorbalssa victorbalssa merged commit c38224e into victorbalssa:develop Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feature Request: view recurring transactions/bills on Home Screen
2 participants