Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marcelweikum:fix/bills #323

Merged
merged 25 commits into from
Jul 29, 2024
Merged

Conversation

marcelweikum
Copy link
Contributor

Hey Victor,

I've fixed issue #321 as discussed. I've made the appearance consistent with the Piggybank tab.

I encountered something strange: if you set the bill repetition to longer than monthly, the nextExpectedMatch date is not provided anymore. To handle this, I introduced the "date_unavailable" locale, which adds "further notice" instead of a date.

Here's how the functionality works:

Unpaid bills show the next expected pay date with the label "Due to " followed by the date and the total amount due. It displays the minimum amount required to fully pay the bill.

Partially paid bills display the percentage paid, a progress bar, the amount paid so far, and the minimum amount required.

Fully paid bills show the label "Paid until" followed by the date. If there is no date available, it says "Paid until further notice."

Let me know if you have any questions or need further adjustments.

Simulator Screenshot Unpaid Simulator Screenshot Partially paid Simulator Screenshot Fully paid

Best,
Marcel

@victorbalssa victorbalssa added the bug Something isn't working label Jul 26, 2024
@victorbalssa victorbalssa changed the title Fixed issue with bills marcelweikum:fix/bills Jul 26, 2024
@victorbalssa victorbalssa added this to the 0.20.0 milestone Jul 26, 2024
@victorbalssa victorbalssa self-requested a review July 26, 2024 16:58
Copy link
Owner

@victorbalssa victorbalssa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcelweikum! approved.

@victorbalssa victorbalssa merged commit ab4fbd9 into victorbalssa:develop Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants