generated from victorbalssa/expo-ticket-app
-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marcelweikum:fix/bills #323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion of the selected color
…the others are random
victorbalssa
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcelweikum! approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Victor,
I've fixed issue #321 as discussed. I've made the appearance consistent with the Piggybank tab.
I encountered something strange: if you set the bill repetition to longer than monthly, the nextExpectedMatch date is not provided anymore. To handle this, I introduced the "date_unavailable" locale, which adds "further notice" instead of a date.
Here's how the functionality works:
Unpaid bills show the next expected pay date with the label "Due to " followed by the date and the total amount due. It displays the minimum amount required to fully pay the bill.
Partially paid bills display the percentage paid, a progress bar, the amount paid so far, and the minimum amount required.
Fully paid bills show the label "Paid until" followed by the date. If there is no date available, it says "Paid until further notice."
Let me know if you have any questions or need further adjustments.
Best,
Marcel