Skip to content

Commit

Permalink
(cqfn#472) - Remove checkstyle suppression
Browse files Browse the repository at this point in the history
  • Loading branch information
victornoel committed May 9, 2020
1 parent 05d4100 commit 33820a0
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions src/main/java/org/jpeek/graph/XmlGraph.java
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,13 @@
import java.util.List;
import java.util.Map;
import org.cactoos.list.ListOf;
import org.cactoos.map.MapOf;
import org.cactoos.scalar.Sticky;
import org.cactoos.scalar.Unchecked;
import org.jpeek.skeleton.Skeleton;

/**
* Graph implementation built on skeleton.
* @since 0.30.9
* @todo #445:30min Continue the work started with extracting XmlMethodCall,
* XmlMethodArgs and XmlMethodSignature, and extract more code from this class
* pertaining to serializing XML to string. The objective is to have tested
* classes and to remove the checkstyle suppression below. Finally consider
* extracting the whole 'build' method body into a separate class extending
* ListEnvelope.
* @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
*/
public final class XmlGraph implements Graph {

Expand Down Expand Up @@ -87,11 +79,12 @@ private static List<Node> build(final Skeleton skeleton) throws IOException {
skeleton.xml().nodes("//class").get(0),
method
).asString()
), skeleton.xml().nodes(
),
skeleton.xml().nodes(
"//methods/method[@ctor='false' and @abstract='false']"
)
);
final Map<String, Node> byname = new MapOf<>(
final Map<String, Node> byname = new org.cactoos.map.Sticky<>(
Node::name,
node -> node,
byxml.values()
Expand Down

0 comments on commit 33820a0

Please sign in to comment.