Basic functions #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubmit
reviewed
Sep 3, 2020
| @@ -0,0 +1,151 @@ | |||
| import React, {useState, useEffect} from 'react'; | |||
There was a problem hiding this comment.
To be honest, I can't go through this file, since it is more complex than the others and I'm short on time right now. It looks good to me though
src/words/Letter.js
Outdated
| return correct ? 'green' : 'red' | ||
| } | ||
|
|
||
| function Letter(props) { |
There was a problem hiding this comment.
Instead of using content, use children instead.
function Letter(props) {
.
.
.
return <span style={style}>
{children}
</span>
}
// call Letter
<Letter>something</Letter>
There was a problem hiding this comment.
how about the isCorrect .how should it be passed?
There was a problem hiding this comment.
Normally via props, you'd just fetch it from there
const { children, isCorrect, andOtherStuff } = props
| @@ -0,0 +1,18 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Good practice for imports
//First level npm and react modules
import React from 'react
import _ from 'lodash'
// Second level absolute imports
import { somethingUsedEverywhere } from 'utils'
// Third level local imports
import Something from "../something" // good to keep 1 maximum of back level
import AnotherSomething from "./anotherSomething"
|
|
||
| const [keyPressed, setKeyPressed] = useState(); | ||
| useEffect(() => { | ||
| const downHandler = (e) => { |
There was a problem hiding this comment.
e to event for more readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if correct keys were typed
Allows user to backspace (go back if keys were pressed by mistake)