Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exportvars feature #11

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Add exportvars feature #11

merged 3 commits into from
Jun 11, 2020

Conversation

brainstorm
Copy link
Contributor

For quickly reusing tokens on arbitrary machines and instances one might be working on.

This is unsafe and dangerous, only use if you know what you are doing ;)

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #11 into master will decrease coverage by 2.61%.
The diff coverage is 61.53%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #11      +/-   ##
===========================================
- Coverage   100.00%   97.38%   -2.62%     
===========================================
  Files            1        1              
  Lines          181      191      +10     
===========================================
+ Hits           181      186       +5     
- Misses           0        5       +5     
Flag Coverage Δ
#unittests 97.38% <61.53%> (-2.62%) ⬇️
Impacted Files Coverage Δ
yawsso/cli.py 97.38% <61.53%> (-2.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797369d...8a24fbb. Read the comment docs.

@brainstorm
Copy link
Contributor Author

Ideally this should work like this:

$ aws sso login && yawsso -e | pbcopy

Unfortunately, yawsso prints quite a lot of INFO via the builtin logger... I reckon it should not output anything to be more UNIX friendly?

@victorskl victorskl self-assigned this Jun 11, 2020
@victorskl victorskl added the feature New feature label Jun 11, 2020
@victorskl victorskl added this to the 0.4.0 milestone Jun 11, 2020
@victorskl
Copy link
Owner

Ideally this should work like this:

$ aws sso login && yawsso -e | pbcopy

Unfortunately, yawsso prints quite a lot of INFO via the builtin logger... I reckon it should not output anything to be more UNIX friendly?

Right! Why do I forget about pipe use case!! 😄 Sure, I will improve logging mechanism.

Merging this. Thanks Roman.

@victorskl victorskl merged commit 06f3bbf into victorskl:master Jun 11, 2020
@brainstorm brainstorm deleted the export_vars branch June 11, 2020 22:28
victorskl added a commit that referenced this pull request Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants