Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageBatteryDetails: hide unused items #1087

Closed
DanielMcInnes opened this issue May 19, 2024 · 3 comments · Fixed by #1164
Closed

PageBatteryDetails: hide unused items #1087

DanielMcInnes opened this issue May 19, 2024 · 3 comments · Fixed by #1164
Assignees
@blammit
Labels
gui-v1 feature parity
Milestone
Version 1.0.0

Comments

@DanielMcInnes
Copy link
Contributor

gui-v1 commit: 8118d8f243bef995b5c8127d5520417668144c82
@DanielMcInnes DanielMcInnes added this to the Version 1.0.0 milestone May 19, 2024
@DanielMcInnes DanielMcInnes mentioned this issue May 22, 2024
Closed
@jpetrell jpetrell self-assigned this May 29, 2024
jpetrell added a commit that referenced this issue May 29, 2024
@jpetrell
Hide unused items on the battery details page
1d54d28 
Fixes #1087.
@jpetrell jpetrell mentioned this issue May 29, 2024
Merged
jpetrell added a commit that referenced this issue May 31, 2024
@jpetrell
Hide unused items on the battery details page
8966e1f 
Fixes #1087.
jpetrell added a commit that referenced this issue May 31, 2024
@jpetrell
Hide unused items on the battery details page
6715c6b 
Fixes #1087.
@chriadam
Copy link
Contributor

As per testing on Wednesday:

  1. Separator should be hidden from e.g. "Lowest cell voltage" etc list items, if the cell id is unknown.
  2. If no battery details are visible / valid, we should hide (or at least disable) the "Details" drilldown in battery device page.

@chriadam chriadam reopened this Jun 20, 2024
@blammit
Copy link
Contributor

blammit commented Jul 12, 2024 •
edited
Loading

If no battery details are visible / valid, we should hide (or at least disable) the "Details" drilldown in battery device page.

This is fixed by #1201

@blammit blammit self-assigned this Jul 16, 2024
@blammit blammit mentioned this issue Jul 16, 2024
Open
@blammit
Copy link
Contributor

blammit commented Jul 16, 2024

Separator should be hidden from e.g. "Lowest cell voltage" etc list items, if the cell id is unknown.

This is of a lower priority and takes more work to resolve due to the way that ListQuantityGroup is built at the moment. I have a created an issue with some related remarks here, so we can close this task as the main issue has been resolved.

@blammit blammit closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blammit blammit

Labels
gui-v1 feature parity
Projects
None yet
Milestone
Version 1.0.0
Development

Successfully merging a pull request may close this issue.

Hide unused items on the battery details page victronenergy/gui-v2
4 participants
@blammit @jpetrell @chriadam @DanielMcInnes