feature: support all data points in the system node #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Note that I just now made an issue for all or part of the above work; and only afterwards found this PR. Here is the issue: |
…ctron into system-node
dirkjanfaber
requested changes
Sep 10, 2021
There was a problem hiding this comment.
We don't want to expose /SystemState for now, as that is also not exposed via modbus_tcp. We could consider generating the services.json file from the excel file in the https://github.com/victronenergy/dbus_modbustcp repository.
Either that, or add a filter that checks the connection type and exposes only the services for the used connection. I'll make a new issue for that.
src/services/services.json
Outdated
| } | ||
| }, | ||
| { | ||
| "path": "/SystemState/State", |
There was a problem hiding this comment.
We don't want to add /SystemState here, as those are not exposed via modbus_tcp.
- This is not exposed via modbus_tcp; we leave them out for now. - Also added enum values (from a vrm export)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.