Fix 16bpp #1
Open
Fix 16bpp #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So nobody else wastes two hours figuring out, like me, what that 20-line function does. I'm not sure what exactly it is supposed to do, so I retained old behaviour.
A painless way to silence tons of warnings about definition of DBMESSAGE
Splitted up into multiple functions, each taking care of one individual step.
There was no API using those structs, therefore they can be put into private header
8bpp is still unsupported and will give only black screen formats aren't hardcoded anymore but returned from SDL instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed the code to support 16bpp and done some refactoring, so I could have listening viewer in my tree. This is hopefuly useful to anyone.
The code shoud be split into multiple files, but I don't want to bother with that right now.