-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to avoid instance clash? #25
Comments
that is weird, 4 MSE_ATTACHED events are triggered, whereas you only have 2 instances (2 MediaSource created). as a consequence, loadSource() is called twice in a row per playlist, there might be something here as well, but the MSE_ATTACHED is not supposed to behave like this. |
also the MediaSource 'sourceopen' event listener is removed after its first trigger: https://github.com/dailymotion/hls.js/blob/master/src/hls.js#L260-L261 |
Highly speculative:
In retrospect I now know see why I had to always destroy an existing instance to make it work with playlists: https://github.com/flowplayer/flowplayer-hlsjs/blob/master/flowplayer.hlsjs.js#L50-L53 From the outside it looks like the Hls context persists, and maybe needs an instance wrapper? I noticed another weird thing, which may be related. On Flowplayer's unload call, normally the video tag is removed. This somehow does not happen with hls.js - if I omit https://github.com/flowplayer/flowplayer-hlsjs/blob/master/flowplayer.hlsjs.js#L196 the tag stays, albeit empty (probably only a timing issue, but maybe it helps to know). Something is very persistent here ;-) |
observer is global and not per instance ... |
@blacktrash it should work now, you can verify with |
or here, gh-pages is now up to date |
Great! Can also be confirmed at http://flowplayer.blacktrash.org/fp6/hlsjs-pure.html |
fixed |
adds 608/708 support for cmaf
This will turn out to be embarrassing for me, but here goes:
How do I create more than one
Hls
instance?This simple example fails miserably: http://flowplayer.blacktrash.org/fp6/hlsjs-pure.html
I'm missing something basic here, but what?
The text was updated successfully, but these errors were encountered: