Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bandwidth estimate public API #2086

Merged
merged 13 commits into from
Jan 22, 2019
Merged

Make bandwidth estimate public API #2086

merged 13 commits into from
Jan 22, 2019

Conversation

Beraliv
Copy link
Contributor

@Beraliv Beraliv commented Jan 21, 2019

This PR will...

create getter for HLS to extract bandwidth estimate

Why is this Pull Request needed?

To load most appropriate chunks based on bandwidth as it's the most accurate estimate

Are there any points in the code the reviewer needs to double check?

No

Resolves issues:

#1904

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

michaelcunningham19
michaelcunningham19 requested changes Jan 21, 2019
View reviewed changes
Copy link
Member

@michaelcunningham19 michaelcunningham19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Some thoughts I had when reviewing the diff:

src/hls.js Outdated Show resolved Hide resolved
tests/unit/hls.js Outdated Show resolved Hide resolved
docs/API.md Outdated Show resolved Hide resolved
johnBartos
johnBartos requested changes Jan 21, 2019
View reviewed changes
docs/API.md Show resolved Hide resolved
johnBartos and others added 3 commits January 21, 2019 22:26
@johnBartos @Beraliv
docs: update
a0465f6 
Co-Authored-By: Beraliv <beraliv.spb@gmail.com>
@Beraliv
docs: update 2
86ec335
@Beraliv
docs: fix link
938eaba
@Beraliv
Copy link
Contributor Author

Beraliv commented Jan 21, 2019

Is everything alright now? @michaelcunningham19 @johnBartos

johnBartos
johnBartos requested changes Jan 21, 2019
View reviewed changes
Copy link
Collaborator

@johnBartos johnBartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just a few test suggestions

tests/unit/controller/abr-controller.js Outdated Show resolved Hide resolved
tests/unit/hls.js Outdated Show resolved Hide resolved
tests/unit/hls.js Outdated Show resolved Hide resolved
tests/unit/hls.js Outdated Show resolved Hide resolved
@michaelcunningham19 michaelcunningham19 merged commit dc6c404 into video-dev:master Jan 22, 2019
@Beraliv Beraliv mentioned this pull request Jan 23, 2019
Merged
3 tasks
@Beraliv Beraliv mentioned this pull request Feb 3, 2019
Merged
9 tasks
@johnBartos johnBartos added this to the 0.13.0 milestone Aug 13, 2019
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
This was referenced Jun 6, 2021
Open
Open
@renovate renovate bot mentioned this pull request Jun 15, 2021
Open
1 task
This was referenced Aug 13, 2022
Merged
Closed
@renovate renovate bot mentioned this pull request Oct 14, 2022
Closed
1 task
This was referenced Nov 4, 2022
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Dec 3, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcunningham19 michaelcunningham19 michaelcunningham19 approved these changes

@johnBartos johnBartos johnBartos approved these changes

Assignees
No one assigned
Labels
Documentation Feature proposal Ready-to-merge
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Beraliv @johnBartos @michaelcunningham19