fix AudioStreamController when media is not attached #2172

mad-gooze · 2019-03-12T14:15:24Z

This PR will...

Fix AudioStreamController for streams with subtitles if media is not attached

Why is this Pull Request needed?

Fixes audioSwitch and logging in AudioStreamController

Reproduce example:

<video id="video" controls></video>
<button onclick="attach()">Attach media</button>

<script>
  var video = document.getElementById('video');
  var hls = new Hls({
    startFragPrefetch: true,
    debug: true,
  });
  // attach();
  hls.loadSource('https://faked-multiple-audio-tracks-qdyvgxaayi.now.sh/index.m3u8');
  hls.startLoad();

  function attach () {
    hls.attachMedia(video);
  }
</script>

on master branch stream will not play after attach

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

changes have been done against master branch, and PR does not conflict
new unit / functional tests have been added (whenever applicable)
API or design changes are documented in API.md

johnBartos · 2019-04-10T17:55:42Z

Good find 👍

author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139648 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139573 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139456 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139292 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556138720 -0600 Update Karma to 3.1.4 for karma-runner/karma@bb022a7 for our single import preprocess. Widevine EME changes Use _generateRequestWithPreferredKeySession in _onNewMediaKeySession Ensure Widevine XHR is open before sending Complete video playback for Widevine EME, begin work on audio Reconfigure EME controller to be promise-based Reset without master merge Release sessions on restart Merge branch 'widevine-eme' of github.com:realeyes-matthew/hls.js into widevine-eme Merge branch 'widevine-eme' of github.com:realeyes-matthew/hls.js into widevine-eme Don't fill the buffer until EME is configured Configure EME controller to use promise to request license Remove eme blocking in Buffer Controller Add separate events for EME configuration Block frag processing until eme is configured Fix bug where keysSet was being emitted repeatedly separate cc bytes into fields, update cea608parser to 1.0.1 updated docs for closed captions note set track mode to disabled, fix line sticking after seek set object props to null instead of using 'delete' use instream id from manifest to determine cc output filter Don't attempt to unset mediakeys on the media on destroy if the media is non-HTTPS Clean up EME controller with comments, update config for EME method revisions, fix typos Remove dist to reset to master build Change getEMELicenseFunc so the user can load licenses specific to the level or audioTrack Update API docs for EME Revert package-lock changes Revert Karma changes Make EME controller optional Fixing diffs add netlify badge to readme (video-dev#2214) so that we qualify for the open source plan https://www.netlify.com/legal/open-source-policy/ fix AudioStreamController when media is not attached (video-dev#2172) Bump stale time to close from 7 days to 60, add more exempt labels use netlify endpoint that includes team so that the sites are created under the new team that has the open source account policy https://open-api.netlify.com/#/default/createSiteInTeam Update design.md This fixes some inconsistencies I noticed while going through this file today id3 TXXX parsing should use exitOnNull (video-dev#2217) Enable null delimiter parsing on TXXX labels, per http://id3.org/id3v2.4.0-frames section 4.2.6 This is achieved by passing true to the already existing existOnNull parameter of utf8ArrayToStr(array, exitOnNull = false) if a TXXX field is detected. per http://id3.org/id3v2.4.0-frames fix for video-dev#2215 fix video-dev#2157 WEBVTT without X-TIMESTAMP-MAP (video-dev#2179) Avoid offsetting cue times with localTime if EXT-X-TIMESTAMP-MAP is not present

author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139648 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139573 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139456 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139292 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556138720 -0600 Update Karma to 3.1.4 for karma-runner/karma@bb022a7 for our single import preprocess. Widevine EME changes Use _generateRequestWithPreferredKeySession in _onNewMediaKeySession Ensure Widevine XHR is open before sending Complete video playback for Widevine EME, begin work on audio Reconfigure EME controller to be promise-based Reset without master merge Release sessions on restart Merge branch 'widevine-eme' of github.com:realeyes-matthew/hls.js into widevine-eme Merge branch 'widevine-eme' of github.com:realeyes-matthew/hls.js into widevine-eme Don't fill the buffer until EME is configured Configure EME controller to use promise to request license Remove eme blocking in Buffer Controller Add separate events for EME configuration Block frag processing until eme is configured Fix bug where keysSet was being emitted repeatedly separate cc bytes into fields, update cea608parser to 1.0.1 updated docs for closed captions note set track mode to disabled, fix line sticking after seek set object props to null instead of using 'delete' use instream id from manifest to determine cc output filter Don't attempt to unset mediakeys on the media on destroy if the media is non-HTTPS Clean up EME controller with comments, update config for EME method revisions, fix typos Remove dist to reset to master build Change getEMELicenseFunc so the user can load licenses specific to the level or audioTrack Update API docs for EME Revert package-lock changes Revert Karma changes Make EME controller optional Fixing diffs add netlify badge to readme (video-dev#2214) so that we qualify for the open source plan https://www.netlify.com/legal/open-source-policy/ fix AudioStreamController when media is not attached (video-dev#2172) Bump stale time to close from 7 days to 60, add more exempt labels use netlify endpoint that includes team so that the sites are created under the new team that has the open source account policy https://open-api.netlify.com/#/default/createSiteInTeam Update design.md This fixes some inconsistencies I noticed while going through this file today id3 TXXX parsing should use exitOnNull (video-dev#2217) Enable null delimiter parsing on TXXX labels, per http://id3.org/id3v2.4.0-frames section 4.2.6 This is achieved by passing true to the already existing existOnNull parameter of utf8ArrayToStr(array, exitOnNull = false) if a TXXX field is detected. per http://id3.org/id3v2.4.0-frames fix for video-dev#2215 fix video-dev#2157 WEBVTT without X-TIMESTAMP-MAP (video-dev#2179) Avoid offsetting cue times with localTime if EXT-X-TIMESTAMP-MAP is not present Re-remove non-EME code to align with master Forgot newline in timeline-controller revert to master Another newline Another newline Spacing issue Another newline Another newline Another newline Another newline

author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139648 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139573 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139456 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139292 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556138720 -0600 Update Karma to 3.1.4 for karma-runner/karma@bb022a7 for our single import preprocess. Widevine EME changes Use _generateRequestWithPreferredKeySession in _onNewMediaKeySession Ensure Widevine XHR is open before sending Complete video playback for Widevine EME, begin work on audio Reconfigure EME controller to be promise-based Reset without master merge Release sessions on restart Merge branch 'widevine-eme' of github.com:realeyes-matthew/hls.js into widevine-eme Merge branch 'widevine-eme' of github.com:realeyes-matthew/hls.js into widevine-eme Don't fill the buffer until EME is configured Configure EME controller to use promise to request license Remove eme blocking in Buffer Controller Add separate events for EME configuration Block frag processing until eme is configured Fix bug where keysSet was being emitted repeatedly separate cc bytes into fields, update cea608parser to 1.0.1 updated docs for closed captions note set track mode to disabled, fix line sticking after seek set object props to null instead of using 'delete' use instream id from manifest to determine cc output filter Don't attempt to unset mediakeys on the media on destroy if the media is non-HTTPS Clean up EME controller with comments, update config for EME method revisions, fix typos Remove dist to reset to master build Change getEMELicenseFunc so the user can load licenses specific to the level or audioTrack Update API docs for EME Revert package-lock changes Revert Karma changes Make EME controller optional Fixing diffs add netlify badge to readme (video-dev#2214) so that we qualify for the open source plan https://www.netlify.com/legal/open-source-policy/ fix AudioStreamController when media is not attached (video-dev#2172) Bump stale time to close from 7 days to 60, add more exempt labels use netlify endpoint that includes team so that the sites are created under the new team that has the open source account policy https://open-api.netlify.com/#/default/createSiteInTeam Update design.md This fixes some inconsistencies I noticed while going through this file today id3 TXXX parsing should use exitOnNull (video-dev#2217) Enable null delimiter parsing on TXXX labels, per http://id3.org/id3v2.4.0-frames section 4.2.6 This is achieved by passing true to the already existing existOnNull parameter of utf8ArrayToStr(array, exitOnNull = false) if a TXXX field is detected. per http://id3.org/id3v2.4.0-frames fix for video-dev#2215 fix video-dev#2157 WEBVTT without X-TIMESTAMP-MAP (video-dev#2179) Avoid offsetting cue times with localTime if EXT-X-TIMESTAMP-MAP is not present Re-remove non-EME code to align with master Forgot newline in timeline-controller revert to master Another newline Another newline Spacing issue Another newline Another newline Another newline Another newline Fix linting errors Update EME errors Fix error comment

author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139648 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139573 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139456 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556139292 -0600 parent 10f1737 author Jamie Stackhouse <contin673@gmail.com> 1551472707 -0400 committer Matthew Thompson <matthew@realeyes.com> 1556138720 -0600 Update Karma to 3.1.4 for karma-runner/karma@bb022a7 for our single import preprocess. Widevine EME changes Use _generateRequestWithPreferredKeySession in _onNewMediaKeySession Ensure Widevine XHR is open before sending Complete video playback for Widevine EME, begin work on audio Reconfigure EME controller to be promise-based Reset without master merge Release sessions on restart Merge branch 'widevine-eme' of github.com:realeyes-matthew/hls.js into widevine-eme Merge branch 'widevine-eme' of github.com:realeyes-matthew/hls.js into widevine-eme Don't fill the buffer until EME is configured Configure EME controller to use promise to request license Remove eme blocking in Buffer Controller Add separate events for EME configuration Block frag processing until eme is configured Fix bug where keysSet was being emitted repeatedly separate cc bytes into fields, update cea608parser to 1.0.1 updated docs for closed captions note set track mode to disabled, fix line sticking after seek set object props to null instead of using 'delete' use instream id from manifest to determine cc output filter Don't attempt to unset mediakeys on the media on destroy if the media is non-HTTPS Clean up EME controller with comments, update config for EME method revisions, fix typos Remove dist to reset to master build Change getEMELicenseFunc so the user can load licenses specific to the level or audioTrack Update API docs for EME Revert package-lock changes Revert Karma changes Make EME controller optional Fixing diffs add netlify badge to readme (video-dev#2214) so that we qualify for the open source plan https://www.netlify.com/legal/open-source-policy/ fix AudioStreamController when media is not attached (video-dev#2172) Bump stale time to close from 7 days to 60, add more exempt labels use netlify endpoint that includes team so that the sites are created under the new team that has the open source account policy https://open-api.netlify.com/#/default/createSiteInTeam Update design.md This fixes some inconsistencies I noticed while going through this file today id3 TXXX parsing should use exitOnNull (video-dev#2217) Enable null delimiter parsing on TXXX labels, per http://id3.org/id3v2.4.0-frames section 4.2.6 This is achieved by passing true to the already existing existOnNull parameter of utf8ArrayToStr(array, exitOnNull = false) if a TXXX field is detected. per http://id3.org/id3v2.4.0-frames fix for video-dev#2215 fix video-dev#2157 WEBVTT without X-TIMESTAMP-MAP (video-dev#2179) Avoid offsetting cue times with localTime if EXT-X-TIMESTAMP-MAP is not present Re-remove non-EME code to align with master Forgot newline in timeline-controller revert to master Another newline Another newline Spacing issue Another newline Another newline Another newline Another newline Fix linting errors Update EME errors Fix error comment Fix EME to listen for encrypted event Update demo for EME changes Cleanup non-EME code

fix AudioStreamController when media is not attached

624a55f

johnBartos approved these changes Apr 10, 2019

View reviewed changes

johnBartos added this to the 0.13.0 milestone Apr 10, 2019

johnBartos added the Bug label Apr 10, 2019

johnBartos merged commit fee971c into video-dev:master Apr 10, 2019

mad-gooze deleted the audio-stream-contoller-no-media branch April 10, 2019 18:18

realeyes-matthew mentioned this pull request Apr 26, 2019

parent 10f1737b4ef3e14e453c8154e6822b00bd00856a realeyes-matthew/hls.js#2

Merged

3 tasks

johnBartos mentioned this pull request Sep 11, 2019

[DNM] PR Test jwplayer/hls.js upgrade to v0.13.x jwplayer/hls.js#244

Closed

3 tasks

snyk-bot mentioned this pull request Mar 8, 2020

[Snyk] Upgrade hls.js from 0.6.11 to 0.13.2 tjenkinson/flowplayer-hlsjs#2

Open

This was referenced Jun 6, 2021

chore(deps): update dependency hls.js to v0.14.17 SevenOutman/vue-aplayer#211

Open

chore(deps): update dependency hls.js to v0.14.17 neuron-digital/wjplayer#34

Open

renovate bot mentioned this pull request Jun 15, 2021

chore(deps): update dependency hls.js to v1 SevenOutman/vue-aplayer#235

Open

1 task

This was referenced Aug 13, 2022

Update dependency hls.js to v0.14.17 phpb-com/video-react#69

Merged

fix(deps): update dependencies (non-major) (studio-v2) sanity-io/sanity-plugin-mux-input#78

Closed

renovate bot mentioned this pull request Oct 14, 2022

fix(deps): update dependencies (non-major) (studio-v2) sanity-io/sanity-plugin-mux-input#122

Closed

1 task

renovate bot mentioned this pull request Dec 3, 2022

fix(deps): update dependencies (non-major) (studio-v2) sanity-io/sanity-plugin-mux-input#169

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix AudioStreamController when media is not attached #2172

fix AudioStreamController when media is not attached #2172

mad-gooze commented Mar 12, 2019 •

edited

Loading

johnBartos commented Apr 10, 2019

fix AudioStreamController when media is not attached #2172

fix AudioStreamController when media is not attached #2172

Conversation

mad-gooze commented Mar 12, 2019 • edited Loading

This PR will...

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

johnBartos commented Apr 10, 2019

mad-gooze commented Mar 12, 2019 •

edited

Loading