Fix audio remuxer out of sequence sample drop regression #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
robwalch
force-pushed
the
bugfix/drop-bad-audio-samples
branch
from
2d2e751
to
e88d540
Compare
…ent were not being dropped, resulting in stretching of audio track duration once appended Test stream (4 second segment with one out of sequence audio sample) https://playertest.longtailvideo.com/adaptive/audio-sample-out-of-sequence/main.m3u8
robwalch
force-pushed
the
bugfix/drop-bad-audio-samples
branch
from
e88d540
to
bf95cdd
Compare
jnatalzia
approved these changes
Aug 7, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix a regression introduced in v0.14.1, in the audio remuxer, where bad samples mid fragment were not being dropped.
Why is this Pull Request needed?
Appending out of order samples results in stretching of audio track duration.
Are there any points in the code the reviewer needs to double check?
Test stream (4 second segment with one out of sequence audio sample) https://playertest.longtailvideo.com/adaptive/audio-sample-out-of-sequence/main.m3u8
The video duration becomes 27 hours:
https://hls-js.netlify.app/demo/?src=https%3A%2F%2Fplayertest.longtailvideo.com%2Fadaptive%2Faudio-sample-out-of-sequence%2Fmain.m3u8&demoConfig=eyJlbmFibGVTdHJlYW1pbmciOnRydWUsImF1dG9SZWNvdmVyRXJyb3IiOnRydWUsImR1bXBmTVA0IjpmYWxzZSwibGV2ZWxDYXBwaW5nIjotMSwibGltaXRNZXRyaWNzIjotMX0=
Resolves issues
#2959
Checklist