Fix Safari decode errors with DTS not increasing when PTS decreases #5710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Increase m2ts->fmp4 remuxed sample dts to prevent decode artifacts and errors in Safari.
Why is this Pull Request needed?
Samples with negative DTS after aligning on PTS can cause decode artifacts and errors when hls.js sets those initial samples' DTS to 0.
Are there any points in the code the reviewer needs to double check?
It's not ideal that hls.js has to modify the decode timeline in order to align the media presentation to 0. This is done to remove large video starting gaps that result from MSE implementations not accounting for or reflecting composition time in the media elements timeline.
In the future, HLS.js could improve by setting SourceBuffer
timestampOffset
before appending, without shifting sample timestamps. That would be a much more involved change as it could impact fragment timing properties and append positions across browsers, so for these reasons this intermediate fix is being made instead.Resolves issues:
Checklist