Custom shouldRetry in retryConfig (follow up) #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pfomin <pfomin@ivi.ru>
|
Hi @PavelFomin90, Sorry for the delay. I merged your PR into this branch and added this change (47e4bb2) so that you could change the retry behavior based on URL as well as status code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Replace httpStatus argument with
LoaderResponseinconfig.shouldRetryWhy is this Pull Request needed?
Allows
config.shouldRetryhandler to useLoaderResponse.urlandLoaderResponse.code(http status) in its reasoning.Are there any points in the code the reviewer needs to double check?
Resolves issues:
#5647
#5658
Checklist