Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust overlapping M2TS AVC timestamps of sample that overlap with previous segment #5805

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Sep 7, 2023

This PR will...

Why is this Pull Request needed?

Prevents vide buffer gaps from being produced on append in Chrome with HLS assets with m2ts segments containing overlapping AVC samples at segment boundaries.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #5759 #4470

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Sep 7, 2023
@robwalch robwalch merged commit b122a39 into master Sep 8, 2023
16 of 17 checks passed
@robwalch robwalch deleted the bugfix/chrome-avc-overlap-m2ts branch September 8, 2023 23:43
@robwalch robwalch mentioned this pull request Sep 12, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hls.Events.ERROR is never received unless HTMLVideoElement is attached to the DOM
1 participant