Add preferManagedMediaSource API.md doc entry for ManagedMediaSource usage
#5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_FLUSHED with removed ranges in ManagedMediaSource "bufferedchange" event
OrenMe
reviewed
Sep 16, 2023
src/controller/buffer-controller.ts
Outdated
| 'bufferedchange', | ||
| (type: SourceBufferName, event: Event) => { | ||
| // If media was ejected check for a change. Added ranges are redundant with changes on 'updateend' event. | ||
| const removedRanges = (event as any).removedRanges; |
There was a problem hiding this comment.
Do we have types for events so it won't be just any?
|
Related to #5542 |
based on w3c proposal w3c/media-source#320
OrenMe
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
preferManagedMediaSourceAPI.md doc entryWhy is this Pull Request needed?
ManagedMediaSource dispatches "bufferedchange" on append and when ejecting media independent of appends. The event includes
removedRangeswhen media is ejected from the buffer.Are there any points in the code the reviewer needs to double check?
Resolves issues:
Checklist