Redundant Stream grouping enhancements #5855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
robwalch
force-pushed
the
feature/respect-groups-with-different-options
branch
2 times, most recently
from
c17a25f
to
978190f
Compare
3 tasks
robwalch
force-pushed
the
feature/respect-groups-with-different-options
branch
3 times, most recently
from
729bfaf
to
f37400b
Compare
Add VIDEO_RANGE and HDCP attriubute values to Redundant Stream grouping Add channels and characteristics to MediaPlaylist Resolves #5302
robwalch
force-pushed
the
feature/respect-groups-with-different-options
branch
from
f37400b
to
77ebd18
Compare
|
Hello @robwalch |
Yes it will. #4571 is still marked for milestone 1.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
audioTracksandsubtitleTracksacross multiple GroupIDs that share the same Variant (HLS Manifest with multi audio is not supported by player #5302)channelsandcharacteristicstoMediaPlaylistobjects (hls.audioTracksandhls.subtitleTracks)Why is this Pull Request needed?
HLS assets can have audio or subtitle groups with different sets of members (#5302). Compliant assets should have the same set of NAME and LANGUAGE options across all groups. In some cases a groups with a more limited set is created containing limited options in a more advanced codec like (multi-channel audio for example).
This change prevents variants ("levels") with different audio or subtitle options from being grouped as Redundant Streams.
channelsandcharacteristicsproperties aid with these changes and upcoming selection API enhancements.Are there any points in the code the reviewer needs to double check?
Resolves issues:
Resolves #5302
Checklist