This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Remove ns.resume() from NetstreamPlayStart #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. |
dmlap
added a commit
that referenced
this pull request
Apr 2, 2015
Remove ns.resume() from NetstreamPlayStart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing issues with ads and autoplay.
The chain of events look something like:
Netstream.Play.Startgets triggered_ns.resume()gets called because we are in autoplayRemoving this line seems to have no affect on regular playback and it doesn't even change the functionality of the
autoplayfunction.Interesting tidbit: Chrome, Safari, and IE11 do not start playback if
autoplayattribute gets set on the video element after load but Firefox does.