This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Small update to #164 #165
Merged
Small update to #164 #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aspects even if _onmetadataFired == true.
When we attempted to ensure that "loadeddata" would never fire before "loadedmetadata" in videojs#122, we also stopped updated video dimensions from propagating to the video view. Retain the boolean to ensure that load events only occur once per video but scope the conditional so that the other effects of new metadata are still run.
|
I'm not able to reliably reproduce the aspect ratio problem but I did regression test on Chrome, Firefox, and IE8. |
|
LG(if a bit weird)TM |
|
Agreed. I was trying to get us back to the state pre-#122 in the metadata handler with as little additional change as possible. |
dmlap
added a commit
to dmlap/video-js-swf
that referenced
this pull request
Jun 23, 2015
Add an entry for videojs#165.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run metadata handler in more circumstances.